linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ldewangan@nvidia.com (Laxman Dewangan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 5/5] ARM: tegra: add spi nodes to Tegra114 DT
Date: Sat, 16 Mar 2013 00:17:43 +0530	[thread overview]
Message-ID: <51436CCF.6040908@nvidia.com> (raw)
In-Reply-To: <51436BB1.8060005@wwwdotorg.org>

On Saturday 16 March 2013 12:12 AM, Stephen Warren wrote:
> On 03/13/2013 01:49 PM, Laxman Dewangan wrote:
>> NVIDIA's Tegra114 has 6 spi controllers. These controllers are
>> redesign on T114 with different register interface.
>> diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
>> +		reg = <0x7000d400 0x200>;
> ...
>> +		reg = <0x7000d600 0x200>;
> ...
>> +		reg = <0x7000d480 0x200>;
> ...
>> +		reg = <0x7000da00 0x200>;
> ...
>> +		reg = <0x7000dc00 0x200>;
> ...
>> +		reg = <0x7000de00 0x200>;
> I assume that third entry should be 0x7000d800 not 0x7000d480; the TRM
> certainly thinks so. I fixed this up when I applied this patch.

Yes, this is bug in my patch and unfortunately exist in tegra20 and 
tegra30 also.

grep d480 tegra*
tegra114.dtsi:        reg = <0x7000d480 0x200>;
tegra20.dtsi:        reg = <0x7000d480 0x200>;
tegra30.dtsi:        reg = <0x7000d480 0x200>;

We need to fix this. I will post a patch now to correct it.


>
> I've applied the series to Tegra's for-3.10/dt branch. I made a few
> node/property ordering changes for consistency, and some capitalization
> fixes in the commit subjects/descriptions.

Thank you very much for taking care of this.

      reply	other threads:[~2013-03-15 18:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 19:49 [PATCH V3 0/5] ARM: DT: tegra114: Add DT entry for different controller Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 1/5] ARM: tegra: add APB DMA nodes to Tegra114 DT Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 2/5] ARM: tegra: add i2c " Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 3/5] ARM: tegra:add aliases and DMA requestor for serial nodes of Tegra114 Laxman Dewangan
2013-03-13 20:02   ` Stephen Warren
2013-03-15 18:26     ` Stephen Warren
2013-03-15 18:42       ` Laxman Dewangan
2013-03-15 18:58         ` Stephen Warren
2013-03-15 19:03           ` Laxman Dewangan
2013-03-15 18:43       ` Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 4/5] ARM: tegra: add KBC nodes to Tegra114 DT Laxman Dewangan
2013-03-13 19:49 ` [PATCH V3 5/5] ARM: tegra: add spi " Laxman Dewangan
2013-03-15 18:42   ` Stephen Warren
2013-03-15 18:47     ` Laxman Dewangan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51436CCF.6040908@nvidia.com \
    --to=ldewangan@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).