From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Tue, 19 Mar 2013 16:27:09 +0530 Subject: [PATCH v3 02/11] clk: davinci - add PSC clock driver In-Reply-To: References: <1351181518-11882-1-git-send-email-m-karicheri2@ti.com> <1351181518-11882-3-git-send-email-m-karicheri2@ti.com> Message-ID: <51484485.3090503@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/29/2012 12:54 AM, Linus Walleij wrote: > On Thu, Oct 25, 2012 at 6:11 PM, Murali Karicheri wrote: > >> This is the driver for the Power Sleep Controller (PSC) hardware >> found on DM SoCs as well Keystone SoCs (c6x). This driver borrowed >> code from arch/arm/mach-davinci/psc.c and implemented the driver >> as per common clock provider API. The PSC module is responsible for >> enabling/disabling the Power Domain and Clock domain for different IPs >> present in the SoC. The driver is configured through the clock data >> passed to the driver through struct clk_psc_data. >> >> Signed-off-by: Murali Karicheri > > Acked-by: Linus Walleij > > Here is some pedantic stuff if you're really bored: > >> diff --git a/drivers/clk/davinci/clk-psc.c b/drivers/clk/davinci/clk-psc.c > (...) >> + ptcmd = 1 << domain; > > ptcmd = BIT(domain); > >> + pdctl = readl(psc_base + PDCTL + 4 * domain); >> + pdctl |= 0x100; > > pdctl |= BIT(8); /* and here a comment explaing what on earth that means */ It turns out this piece of code is superfluous and the exact same thing is being done again just down below. Thanks, Sekhar