From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: mvebu: fix checking for SoC specific controls
Date: Tue, 19 Mar 2013 20:41:41 +0100 [thread overview]
Message-ID: <5148BF75.8080204@gmail.com> (raw)
In-Reply-To: <1363720062-21395-1-git-send-email-simon.guinot@sequanux.org>
On 03/19/2013 08:07 PM, Simon Guinot wrote:
> This patch fixes a minor bug (probably due to a typo) while checking
> the SoC specific controls in mvebu_pinctrl_probe().
>
> Signed-off-by: Simon Guinot<simon.guinot@sequanux.org>
Simon,
good catch! The patch looks sane to me, so
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> ---
> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mvebu/pinctrl-mvebu.c b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> index c689c04..2d2f0a4 100644
> --- a/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> +++ b/drivers/pinctrl/mvebu/pinctrl-mvebu.c
> @@ -620,7 +620,7 @@ int mvebu_pinctrl_probe(struct platform_device *pdev)
>
> /* special soc specific control */
> if (ctrl->mpp_get || ctrl->mpp_set) {
> - if (!ctrl->name || !ctrl->mpp_set || !ctrl->mpp_set) {
> + if (!ctrl->name || !ctrl->mpp_get || !ctrl->mpp_set) {
> dev_err(&pdev->dev, "wrong soc control info\n");
> return -EINVAL;
> }
next prev parent reply other threads:[~2013-03-19 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 19:07 [PATCH] pinctrl: mvebu: fix checking for SoC specific controls Simon Guinot
2013-03-19 19:41 ` Sebastian Hesselbarth [this message]
2013-03-21 17:51 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148BF75.8080204@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).