From: smoch@web.de (Soeren Moch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] USB: EHCI: fix for leaking isochronous data
Date: Thu, 21 Mar 2013 22:52:30 +0100 [thread overview]
Message-ID: <514B811E.2040209@web.de> (raw)
In-Reply-To: <201303211910.31473.arnd@arndb.de>
On 21.03.2013 20:10, Arnd Bergmann wrote:
> On Thursday 21 March 2013, Jason Cooper wrote:
>> On Thu, Mar 21, 2013 at 06:04:59PM +0100, Soeren Moch wrote:
>
>>>
>>> Now I found out what is going on here:
>>>
>>> In itd_urb_transaction() we allocate 9 iTDs for each URB with
>>> number_of_packets == 64 in my case. The iTDs are added to
>>> sched->td_list. For a frame-aligned scheduling we need 8 iTDs, the
>>> 9th one is released back to the front of the streams free_list in
>>> iso_sched_free(). This iTD was cleared after allocation and has a
>>> frame number of 0 now. So for each allocation when now_frame == 0 we
>>> allocate from the dma_pool, not from the free_list. The attached
>>> patch invalidates the frame number in each iTD before it is sent to
>>> the scheduler. This fixes the problem without the need to iterate
>>> over a iTD list.
>>>
>>> Signed-off-by: Soeren Moch <smoch@web.de>
>>
>> Wow! Great work Soeren! Talk about a long road to a small fix. Thanks
>> for keeping after it.
>
> +1
>
> I hardly understand half of the description above, but that much sounds
> plausible. Is this a bug fix that should get backported to stable kernels?
>
> Arnd
>
I think this patch should go to stable kernels, too. But I'm not an
expert here...
Soeren
next prev parent reply other threads:[~2013-03-21 21:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.44L0.1302211337580.1529-100000@iolanthe.rowland.org>
2013-03-10 18:45 ` [PATCH] USB: EHCI: fix for leaking isochronous data Soeren Moch
2013-03-10 20:59 ` Alan Stern
2013-03-14 18:48 ` Soeren Moch
2013-03-14 20:22 ` Soeren Moch
2013-03-14 20:32 ` Alan Stern
2013-03-14 20:51 ` Soeren Moch
2013-03-14 21:33 ` Alan Stern
2013-03-15 0:00 ` Soeren Moch
2013-03-15 14:30 ` Alan Stern
2013-03-16 2:10 ` Soeren Moch
2013-03-16 17:39 ` Alan Stern
2013-03-17 16:56 ` Soeren Moch
2013-03-17 17:36 ` Alan Stern
2013-03-17 17:39 ` Alan Stern
2013-03-21 17:04 ` Soeren Moch
2013-03-21 17:33 ` Jason Cooper
2013-03-21 19:10 ` Arnd Bergmann
2013-03-21 19:34 ` Michael Trimarchi
2013-03-21 21:52 ` Soeren Moch [this message]
2013-03-21 21:06 ` Alan Stern
2013-03-21 21:12 ` Alan Stern
2013-03-21 21:20 ` Andrew Lunn
2013-03-21 22:16 ` Soeren Moch
2013-03-22 14:24 ` Alan Stern
2013-03-21 21:45 ` Soeren Moch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514B811E.2040209@web.de \
--to=smoch@web.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).