From mboxrd@z Thu Jan 1 00:00:00 1970 From: rickard.andersson@stericsson.com (Rickard Andersson) Date: Fri, 22 Mar 2013 09:30:32 +0100 Subject: [PATCH 5/6] ARM: ux500: move PRCMU functions into the CPUidle driver In-Reply-To: <514AFD67.20205@linaro.org> References: <1363866553-15054-1-git-send-email-linus.walleij@stericsson.com> <1363866553-15054-6-git-send-email-linus.walleij@stericsson.com> <514AF99F.7040100@stericsson.com> <514AFD67.20205@linaro.org> Message-ID: <514C16A8.2080002@stericsson.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/21/2013 01:30 PM, Daniel Lezcano wrote: > On 03/21/2013 01:14 PM, Rickard Andersson wrote: >> On 03/21/2013 12:49 PM, Linus WALLEIJ wrote: >>> From: Linus Walleij >>> >>> We are trying to decompose and decentralize the code in >>> the DB8500 PRCMU out into subdrivers. The CPUidle code is >>> calling down into the PRCMU driver basically just to access >>> these registers, so let's remap them locally in the CPUidle >>> driver and move the code there, simply. Besides, the PRCMU >>> code was poking around in the GIC which is the responsibility >>> of the machine. >>> >>> Cc: Daniel Lezcano >>> Cc: Rickard Andersson >>> Cc: Samuel Ortiz >>> Signed-off-by: Linus Walleij >>> --- >>> Sam, I'm requesting an ACK for taking this through the >>> ARM SoC tree. >>> --- >> This functionality will be used by the platform suspend operation also >> which I am currently working on. So I would prefer if you can move it to >> a separate file instead so it can be used by suspend as well. I >> recommend to have it the same way we have it in our internal track i.e. >> a file called pm.c in the machine. > That would be nice to move this driver to drivers/cpuidle. > > If you are ok with that, I can take care of moving the driver to this > directory and then create the pm.c file in the mach-ux500 to move the > prcmu specific code inside. Meanwhile this patch can be merged to group > the prcmu code needed for the driver and can be easily identified. > > > > It is ok to me. BR Rickard