From mboxrd@z Thu Jan 1 00:00:00 1970 From: daniel.lezcano@linaro.org (Daniel Lezcano) Date: Tue, 26 Mar 2013 10:55:43 +0100 Subject: [PATCH 01/15] timer: move enum definition out of ifdef section In-Reply-To: <515125DB.2040806@ti.com> References: <1364234140-514-1-git-send-email-daniel.lezcano@linaro.org> <1364234140-514-2-git-send-email-daniel.lezcano@linaro.org> <515125DB.2040806@ti.com> Message-ID: <5151709F.1030207@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/26/2013 05:36 AM, Santosh Shilimkar wrote: > On Monday 25 March 2013 11:25 PM, Daniel Lezcano wrote: >> The next patch will setup automatically the broadcast timer for >> the different cpuidle driver when one idle state stops its timer. >> This will be part of the generic code. >> >> But some ARM boards, like s3c64xx, uses cpuidle but without the >> CONFIG_GENERIC_CLOCKEVENTS_BUILD set. Hence the cpuidle framework >> will be compiled with the code supposed to be generic, that is >> with clockevents_notify and the different enum, but will fail to >> compile because the enum is not defined. >> >> Also the function clockevents_notify is a noop macro, this is fine >> except the usual code is: >> >> int cpu = smp_processor_id(); >> clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ON, &cpu); >> >> and that raises a warning telling the variable 'cpu' is not used. >> >> Move the clock_event_nofitiers enum definition out of the >> CONFIG_GENERIC_CLOCKEVENTS_BUILD section to prevent a compilation >> error when these are used in the code. >> >> Change the clockevents_notify macro to a static inline noop function >> to prevent a compilation warning. >> >> Signed-off-by: Daniel Lezcano >> --- > > So why can't s3c64xx enable "CONFIG_GENERIC_CLOCKEVENTS_BUILD" if they > wants to use broadcast notfiers ? May be am missing something. They won't use broadcast notifiers but the cpuidle code 'drivers/cpuidle/cpuidle.c' has a generic code using it. It does not compile because an enum definition is inside the block CONFIG_GENERIC_CLOCKEVENTS_BUILD. ... if (drv->states[next_state].flags & CPUIDLE_FLAG_TIMER_STOP) clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu); ... clockevents_notify will be a noop (this is ok), but CLOCK_EVT_NOTIFY_BROADCAST_ENTER won't be defined, so error at compile time. -- Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog