IMX: board hardware macro

IMX: board hardware macro

[Daniel Lezcano]

HI all,

is there a macro to tell if the board is iMX51 and iMX6Q ?

I would like to do the same as:

static int __init tegra_cpuidle_init(void)
{
int ret;

switch (tegra_chip_id) {
case TEGRA20:
ret = tegra20_cpuidle_init();
break;
case TEGRA30:
ret = tegra30_cpuidle_init();
break;
case TEGRA114:
ret = tegra114_cpuidle_init();
break;
default:
ret = -ENODEV;
break;
}

return ret;
}
device_initcall(tegra_cpuidle_init);

Thanks in advance

-- Daniel


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

IMX: board hardware macro

[Shawn Guo]

On Tue, Mar 26, 2013 at 11:31:26PM +0100, Daniel Lezcano wrote:
> HI all,
> 
> is there a macro to tell if the board is iMX51 and iMX6Q ?
> 
> I would like to do the same as:
> 
> static int __init tegra_cpuidle_init(void)
> {
> int ret;
> 
> switch (tegra_chip_id) {
> case TEGRA20:
> ret = tegra20_cpuidle_init();
> break;
> case TEGRA30:
> ret = tegra30_cpuidle_init();
> break;
> case TEGRA114:
> ret = tegra114_cpuidle_init();
> break;
> default:
> ret = -ENODEV;
> break;
> }
> 
> return ret;
> }
> device_initcall(tegra_cpuidle_init);

The global initcall is something that we are removing for multiplatform
build.  Please do not add it back.

Shawn

IMX: board hardware macro

[Daniel Lezcano]

On 03/27/2013 07:33 AM, Shawn Guo wrote:
> On Tue, Mar 26, 2013 at 11:31:26PM +0100, Daniel Lezcano wrote:
>> HI all,
>>
>> is there a macro to tell if the board is iMX51 and iMX6Q ?
>>
>> I would like to do the same as:
>>
>> static int __init tegra_cpuidle_init(void)
>> {
>> int ret;
>>
>> switch (tegra_chip_id) {
>> case TEGRA20:
>> ret = tegra20_cpuidle_init();
>> break;
>> case TEGRA30:
>> ret = tegra30_cpuidle_init();
>> break;
>> case TEGRA114:
>> ret = tegra114_cpuidle_init();
>> break;
>> default:
>> ret = -ENODEV;
>> break;
>> }
>>
>> return ret;
>> }
>> device_initcall(tegra_cpuidle_init);
> 
> The global initcall is something that we are removing for multiplatform
> build.  Please do not add it back.

Ok, sure. I won't add it back.

Do these macros exist ?

Thanks
  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

IMX: board hardware macro

[Shawn Guo]

On Wed, Mar 27, 2013 at 10:13:17AM +0100, Daniel Lezcano wrote:
> Do these macros exist ?

There is cpu_is_mx51(), but no cpu_is_mx6() stuff.  I do not understand
why these are needed.  The cpuidle initialization should be done in SoC
specific hook like how it's done for imx6q right now.  So why do you
need such macros?

Shawn

IMX: board hardware macro

[Daniel Lezcano]

On 03/27/2013 01:34 PM, Shawn Guo wrote:
> On Wed, Mar 27, 2013 at 10:13:17AM +0100, Daniel Lezcano wrote:
>> Do these macros exist ?
> 
> There is cpu_is_mx51(), but no cpu_is_mx6() stuff.  I do not understand
> why these are needed.  The cpuidle initialization should be done in SoC
> specific hook like how it's done for imx6q right now.  So why do you
> need such macros?

Well I am sure that will fit, but I wanted to create a single cpuidle
init function for all the platforms in order to encapsulate the cpuidle
drivers and then with the incoming patchset, factor out the code.

I will send a RFC for the changes, so we can discuss about it and choose
the direction you think more convenient to unify the code across the
different cpuidle drivers.

Thanks
  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog