linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4
Date: Thu, 28 Mar 2013 21:19:01 +0100	[thread overview]
Message-ID: <5154A5B5.7@gmail.com> (raw)
In-Reply-To: <20130328181425.GE3368@n2100.arm.linux.org.uk>

On 03/28/2013 07:14 PM, Russell King - ARM Linux wrote:
> On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote:
>> On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote:
>>> The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using
>>> CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable
>>> iWMMXt extensions on Dove.
>>>
>>> Signed-off-by: Sebastian Hesselbarth<sebastian.hesselbarth@gmail.com>
>>> ---
>>> Cc: Russell King<linux@arm.linux.org.uk>
>>> Cc: Jason Cooper<jason@lakedaemon.net>
>>> Cc: Andrew Lunn<andrew@lunn.ch>
>>> Cc: linux-arm-kernel at lists.infradead.org
>>> Cc: linux-kernel at vger.kernel.org
>>> ---
>>>   arch/arm/Kconfig |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Hmmm, I'm getting (with dove_defconfig):
>>
>> arch/arm/kernel/built-in.o: In function `iwmmxt_do':
>> /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release'
>> /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch'
>> make: *** [vmlinux] Error 1
>
> Looks to me like PJ4 IWMMXT support wasn't properly tested out when it
> was submitted - it's possible to end up with pj4-cp0.c built without
> the IWMMXT code that it depends on being built...

Russel, Jason,

do we force iWMMXt on CPU_PJ4 or should there be some #ifdef'ery if 
IWMMXT is not selected?

Sebastian

  reply	other threads:[~2013-03-28 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 15:06 [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4 Sebastian Hesselbarth
2013-03-26  8:28 ` Andrew Lunn
2013-03-28 17:06 ` Jason Cooper
2013-03-28 18:14   ` Russell King - ARM Linux
2013-03-28 20:19     ` Sebastian Hesselbarth [this message]
2013-03-28 21:04       ` Russell King - ARM Linux
2013-03-29  1:18         ` Jason Cooper
2013-04-29 16:50 ` Jason Cooper
2013-04-29 19:26 ` [PATCH RESEND] " Sebastian Hesselbarth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5154A5B5.7@gmail.com \
    --to=sebastian.hesselbarth@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).