* [PATCH] ARM: at91: dts: add adc resolution stuff
@ 2013-03-29 9:13 ludovic.desroches at atmel.com
2013-03-29 9:47 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: ludovic.desroches at atmel.com @ 2013-03-29 9:13 UTC (permalink / raw)
To: linux-arm-kernel
From: Ludovic Desroches <ludovic.desroches@atmel.com>
Add the ADC low and high resolution configuration and which one to use.
Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
Hi,
This patch is a split from this set of patches:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321
Then device tree changes can go through ARM-SOC and driver changes through the
iio subsystem.
Regards
Ludovic
arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
arch/arm/boot/dts/at91sam9x5.dtsi | 3 +++
3 files changed, 9 insertions(+)
diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
index cb7bcc5..367a604 100644
--- a/arch/arm/boot/dts/at91sam9260.dtsi
+++ b/arch/arm/boot/dts/at91sam9260.dtsi
@@ -484,6 +484,9 @@
atmel,adc-drdy-mask = <0x10000>;
atmel,adc-status-register = <0x1c>;
atmel,adc-trigger-register = <0x04>;
+ atmel,adc-res = <8 10>;
+ atmel,adc-res-names = "lowres", "highres";
+ atmel,adc-use-res = "highres";
trigger at 0 {
trigger-name = "timer-counter-0";
diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
index 6b1d4ca..0fa28af 100644
--- a/arch/arm/boot/dts/at91sam9g45.dtsi
+++ b/arch/arm/boot/dts/at91sam9g45.dtsi
@@ -484,6 +484,9 @@
atmel,adc-drdy-mask = <0x10000>;
atmel,adc-status-register = <0x1c>;
atmel,adc-trigger-register = <0x08>;
+ atmel,adc-res = <8 10>;
+ atmel,adc-res-names = "lowres", "highres";
+ atmel,adc-use-res = "highres";
trigger at 0 {
trigger-name = "external-rising";
diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
index a98c0d5..08bcdd7 100644
--- a/arch/arm/boot/dts/at91sam9x5.dtsi
+++ b/arch/arm/boot/dts/at91sam9x5.dtsi
@@ -505,6 +505,9 @@
atmel,adc-drdy-mask = <0x1000000>;
atmel,adc-status-register = <0x30>;
atmel,adc-trigger-register = <0xc0>;
+ atmel,adc-res = <8 10>;
+ atmel,adc-res-names = "lowres", "highres";
+ atmel,adc-use-res = "highres";
trigger at 0 {
trigger-name = "external-rising";
--
1.7.11.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91: dts: add adc resolution stuff
2013-03-29 9:13 [PATCH] ARM: at91: dts: add adc resolution stuff ludovic.desroches at atmel.com
@ 2013-03-29 9:47 ` Jonathan Cameron
2013-03-29 14:37 ` Nicolas Ferre
2013-03-29 16:28 ` Jean-Christophe PLAGNIOL-VILLARD
0 siblings, 2 replies; 5+ messages in thread
From: Jonathan Cameron @ 2013-03-29 9:47 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2013 09:13 AM, ludovic.desroches at atmel.com wrote:
> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> Add the ADC low and high resolution configuration and which one to use.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> ---
>
> Hi,
>
> This patch is a split from this set of patches:
> http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321
>
> Then device tree changes can go through ARM-SOC and driver changes through the
> iio subsystem.
I am guessing the IIO side is to follow. Even when posting series where it different
bits are to go through different trees, it is useful to have them in one series so that
people can see the whole result.
>
> Regards
>
> Ludovic
>
> arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
> arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
> arch/arm/boot/dts/at91sam9x5.dtsi | 3 +++
> 3 files changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> index cb7bcc5..367a604 100644
> --- a/arch/arm/boot/dts/at91sam9260.dtsi
> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> @@ -484,6 +484,9 @@
> atmel,adc-drdy-mask = <0x10000>;
> atmel,adc-status-register = <0x1c>;
> atmel,adc-trigger-register = <0x04>;
> + atmel,adc-res = <8 10>;
> + atmel,adc-res-names = "lowres", "highres";
> + atmel,adc-use-res = "highres";
>
> trigger at 0 {
> trigger-name = "timer-counter-0";
> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> index 6b1d4ca..0fa28af 100644
> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> @@ -484,6 +484,9 @@
> atmel,adc-drdy-mask = <0x10000>;
> atmel,adc-status-register = <0x1c>;
> atmel,adc-trigger-register = <0x08>;
> + atmel,adc-res = <8 10>;
> + atmel,adc-res-names = "lowres", "highres";
> + atmel,adc-use-res = "highres";
>
> trigger at 0 {
> trigger-name = "external-rising";
> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> index a98c0d5..08bcdd7 100644
> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> @@ -505,6 +505,9 @@
> atmel,adc-drdy-mask = <0x1000000>;
> atmel,adc-status-register = <0x30>;
> atmel,adc-trigger-register = <0xc0>;
> + atmel,adc-res = <8 10>;
> + atmel,adc-res-names = "lowres", "highres";
> + atmel,adc-use-res = "highres";
>
> trigger at 0 {
> trigger-name = "external-rising";
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91: dts: add adc resolution stuff
2013-03-29 9:47 ` Jonathan Cameron
@ 2013-03-29 14:37 ` Nicolas Ferre
2013-04-02 18:13 ` Jonathan Cameron
2013-03-29 16:28 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 1 reply; 5+ messages in thread
From: Nicolas Ferre @ 2013-03-29 14:37 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2013 10:47 AM, Jonathan Cameron :
> On 03/29/2013 09:13 AM, ludovic.desroches at atmel.com wrote:
>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>
>> Add the ADC low and high resolution configuration and which one to use.
>>
>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>
>> ---
>>
>> Hi,
>>
>> This patch is a split from this set of patches:
>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321
>>
>> Then device tree changes can go through ARM-SOC and driver changes through the
>> iio subsystem.
> I am guessing the IIO side is to follow. Even when posting series where it different
> bits are to go through different trees, it is useful to have them in one series so that
> people can see the whole result.
Yes, a v2 series is coming. In fact, I asked Ludovic to post his .dtsi
modifications separately because:
- From the fist discussion, it seemed that we reached a consensus and
that the current binding is okay
- I have to reassemble a pull-request to arm-soc maintainers for 3.10
and it seems that is is time to collect all material.
So, I plan to stack this update of AT91 device tree files real soon. If
you want to give me your acknowledgement once you have read the whole
series, let me know...
Best regards,
>> arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
>> arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
>> arch/arm/boot/dts/at91sam9x5.dtsi | 3 +++
>> 3 files changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
>> index cb7bcc5..367a604 100644
>> --- a/arch/arm/boot/dts/at91sam9260.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
>> @@ -484,6 +484,9 @@
>> atmel,adc-drdy-mask = <0x10000>;
>> atmel,adc-status-register = <0x1c>;
>> atmel,adc-trigger-register = <0x04>;
>> + atmel,adc-res = <8 10>;
>> + atmel,adc-res-names = "lowres", "highres";
>> + atmel,adc-use-res = "highres";
>>
>> trigger at 0 {
>> trigger-name = "timer-counter-0";
>> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
>> index 6b1d4ca..0fa28af 100644
>> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
>> @@ -484,6 +484,9 @@
>> atmel,adc-drdy-mask = <0x10000>;
>> atmel,adc-status-register = <0x1c>;
>> atmel,adc-trigger-register = <0x08>;
>> + atmel,adc-res = <8 10>;
>> + atmel,adc-res-names = "lowres", "highres";
>> + atmel,adc-use-res = "highres";
>>
>> trigger at 0 {
>> trigger-name = "external-rising";
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index a98c0d5..08bcdd7 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -505,6 +505,9 @@
>> atmel,adc-drdy-mask = <0x1000000>;
>> atmel,adc-status-register = <0x30>;
>> atmel,adc-trigger-register = <0xc0>;
>> + atmel,adc-res = <8 10>;
>> + atmel,adc-res-names = "lowres", "highres";
>> + atmel,adc-use-res = "highres";
>>
>> trigger at 0 {
>> trigger-name = "external-rising";
>>
>
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91: dts: add adc resolution stuff
2013-03-29 9:47 ` Jonathan Cameron
2013-03-29 14:37 ` Nicolas Ferre
@ 2013-03-29 16:28 ` Jean-Christophe PLAGNIOL-VILLARD
1 sibling, 0 replies; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2013-03-29 16:28 UTC (permalink / raw)
To: linux-arm-kernel
On 09:47 Fri 29 Mar , Jonathan Cameron wrote:
> On 03/29/2013 09:13 AM, ludovic.desroches at atmel.com wrote:
> > From: Ludovic Desroches <ludovic.desroches@atmel.com>
> >
> > Add the ADC low and high resolution configuration and which one to use.
> >
> > Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>
> > ---
> >
> > Hi,
> >
> > This patch is a split from this set of patches:
> > http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321
> >
> > Then device tree changes can go through ARM-SOC and driver changes through the
> > iio subsystem.
> I am guessing the IIO side is to follow. Even when posting series where it different
> bits are to go through different trees, it is useful to have them in one series so that
> people can see the whole result.
I agree too
Ludo please resend the whole series
Best Regards,
J.
>
>
> >
> > Regards
> >
> > Ludovic
> >
> > arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
> > arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
> > arch/arm/boot/dts/at91sam9x5.dtsi | 3 +++
> > 3 files changed, 9 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
> > index cb7bcc5..367a604 100644
> > --- a/arch/arm/boot/dts/at91sam9260.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9260.dtsi
> > @@ -484,6 +484,9 @@
> > atmel,adc-drdy-mask = <0x10000>;
> > atmel,adc-status-register = <0x1c>;
> > atmel,adc-trigger-register = <0x04>;
> > + atmel,adc-res = <8 10>;
> > + atmel,adc-res-names = "lowres", "highres";
> > + atmel,adc-use-res = "highres";
> >
> > trigger at 0 {
> > trigger-name = "timer-counter-0";
> > diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
> > index 6b1d4ca..0fa28af 100644
> > --- a/arch/arm/boot/dts/at91sam9g45.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
> > @@ -484,6 +484,9 @@
> > atmel,adc-drdy-mask = <0x10000>;
> > atmel,adc-status-register = <0x1c>;
> > atmel,adc-trigger-register = <0x08>;
> > + atmel,adc-res = <8 10>;
> > + atmel,adc-res-names = "lowres", "highres";
> > + atmel,adc-use-res = "highres";
> >
> > trigger at 0 {
> > trigger-name = "external-rising";
> > diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
> > index a98c0d5..08bcdd7 100644
> > --- a/arch/arm/boot/dts/at91sam9x5.dtsi
> > +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
> > @@ -505,6 +505,9 @@
> > atmel,adc-drdy-mask = <0x1000000>;
> > atmel,adc-status-register = <0x30>;
> > atmel,adc-trigger-register = <0xc0>;
> > + atmel,adc-res = <8 10>;
> > + atmel,adc-res-names = "lowres", "highres";
> > + atmel,adc-use-res = "highres";
> >
> > trigger at 0 {
> > trigger-name = "external-rising";
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: at91: dts: add adc resolution stuff
2013-03-29 14:37 ` Nicolas Ferre
@ 2013-04-02 18:13 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2013-04-02 18:13 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2013 02:37 PM, Nicolas Ferre wrote:
> On 03/29/2013 10:47 AM, Jonathan Cameron :
>> On 03/29/2013 09:13 AM, ludovic.desroches at atmel.com wrote:
>>> From: Ludovic Desroches <ludovic.desroches@atmel.com>
>>>
>>> Add the ADC low and high resolution configuration and which one to use.
>>>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
>>
>>> ---
>>>
>>> Hi,
>>>
>>> This patch is a split from this set of patches:
>>> http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321
>>>
>>> Then device tree changes can go through ARM-SOC and driver changes through the
>>> iio subsystem.
>> I am guessing the IIO side is to follow. Even when posting series where it different
>> bits are to go through different trees, it is useful to have them in one series so that
>> people can see the whole result.
>
> Yes, a v2 series is coming. In fact, I asked Ludovic to post his .dtsi
> modifications separately because:
> - From the fist discussion, it seemed that we reached a consensus and
> that the current binding is okay
Consensus is probably putting it a bit strongly given Maxime's comments
but as there was no specific alternative suggested and they Maxime
was raising general issues rathe rthan specifics, I'll take the
iio side of these as is.
> - I have to reassemble a pull-request to arm-soc maintainers for 3.10
> and it seems that is is time to collect all material.
>
> So, I plan to stack this update of AT91 device tree files real soon. If
> you want to give me your acknowledgement once you have read the whole
> series, let me know...
>
> Best regards,
>
>
>>> arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
>>> arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
>>> arch/arm/boot/dts/at91sam9x5.dtsi | 3 +++
>>> 3 files changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi
>>> index cb7bcc5..367a604 100644
>>> --- a/arch/arm/boot/dts/at91sam9260.dtsi
>>> +++ b/arch/arm/boot/dts/at91sam9260.dtsi
>>> @@ -484,6 +484,9 @@
>>> atmel,adc-drdy-mask = <0x10000>;
>>> atmel,adc-status-register = <0x1c>;
>>> atmel,adc-trigger-register = <0x04>;
>>> + atmel,adc-res = <8 10>;
>>> + atmel,adc-res-names = "lowres", "highres";
>>> + atmel,adc-use-res = "highres";
>>>
>>> trigger at 0 {
>>> trigger-name = "timer-counter-0";
>>> diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi
>>> index 6b1d4ca..0fa28af 100644
>>> --- a/arch/arm/boot/dts/at91sam9g45.dtsi
>>> +++ b/arch/arm/boot/dts/at91sam9g45.dtsi
>>> @@ -484,6 +484,9 @@
>>> atmel,adc-drdy-mask = <0x10000>;
>>> atmel,adc-status-register = <0x1c>;
>>> atmel,adc-trigger-register = <0x08>;
>>> + atmel,adc-res = <8 10>;
>>> + atmel,adc-res-names = "lowres", "highres";
>>> + atmel,adc-use-res = "highres";
>>>
>>> trigger at 0 {
>>> trigger-name = "external-rising";
>>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi b/arch/arm/boot/dts/at91sam9x5.dtsi
>>> index a98c0d5..08bcdd7 100644
>>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>>> @@ -505,6 +505,9 @@
>>> atmel,adc-drdy-mask = <0x1000000>;
>>> atmel,adc-status-register = <0x30>;
>>> atmel,adc-trigger-register = <0xc0>;
>>> + atmel,adc-res = <8 10>;
>>> + atmel,adc-res-names = "lowres", "highres";
>>> + atmel,adc-use-res = "highres";
>>>
>>> trigger at 0 {
>>> trigger-name = "external-rising";
>>>
>>
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-02 18:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-29 9:13 [PATCH] ARM: at91: dts: add adc resolution stuff ludovic.desroches at atmel.com
2013-03-29 9:47 ` Jonathan Cameron
2013-03-29 14:37 ` Nicolas Ferre
2013-04-02 18:13 ` Jonathan Cameron
2013-03-29 16:28 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).