From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization
Date: Fri, 29 Mar 2013 16:23:59 +0530 [thread overview]
Message-ID: <515572C7.1030309@ti.com> (raw)
In-Reply-To: <515570DF.5010608@linaro.org>
On Friday 29 March 2013 04:15 PM, Daniel Lezcano wrote:
> On 03/29/2013 11:38 AM, Santosh Shilimkar wrote:
>> On Friday 29 March 2013 04:01 PM, Daniel Lezcano wrote:
>>> The driver is initialized several times. This is wrong and if the
>>> return code of the function was checked, it will return -EINVAL.
>>>
>>> Move this initialization out of the loop.
>>>
>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>>> ---
>> Fix for this is already and v2 of the patch is here [1]
>
> Ah, ok. Thanks for reviewing the patch.
>
> Can we find a solution to have a single entry point to sumbit patches
> for all the cpuidle drivers ?
>
> Otherwise, consolidating them is a pain: a patch for the samsung tree,
> another one for the at91 tree, etc ... and wait for all the trees to
> sync before continuing to consolidate the code.
>
> Wouldn't be worth to move these drivers under the PM umbrella instead of
> the SoC specific code ?
>
> Any idea to simplify the cpuidle consolidation and maintenance ?
>
Fisrtly patches get posted to right mailing list based on where the
code resides. So one must keep a watch on LAKML for the patches.
Talking specific to OMAP idle code, there is plan to move
to drivers/idle/* but for that to happen there are some PRM/CM
dependency for which also driver movement is planned. Once
that happen, OMAP idle will find its way in drivers/idle/*
next prev parent reply other threads:[~2013-03-29 10:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-29 10:31 [PATCH 1/9] ARM: cpuidle: remove useless declaration Daniel Lezcano
2013-03-29 10:31 ` [PATCH 2/9] ARM: shmobile: pm: fix init sections Daniel Lezcano
2013-03-29 10:31 ` [PATCH 3/9] ARM: shmobile: cpuidle: remove useless WFI function Daniel Lezcano
2013-03-29 10:31 ` [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization Daniel Lezcano
2013-03-29 10:38 ` Santosh Shilimkar
2013-03-29 10:45 ` Daniel Lezcano
2013-03-29 10:53 ` Santosh Shilimkar [this message]
2013-03-29 11:23 ` Daniel Lezcano
2013-03-29 11:31 ` Santosh Shilimkar
2013-03-29 11:56 ` Amit Kucheria
2013-03-29 12:20 ` Santosh Shilimkar
2013-03-29 12:50 ` Amit Kucheria
2013-03-29 15:10 ` Santosh Shilimkar
2013-03-29 15:50 ` How to facilitate the cpuidle drivers to go to the same direction (Was: Re: [PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization) Daniel Lezcano
2013-03-31 11:14 ` Rafael J. Wysocki
2013-04-01 6:05 ` Deepthi Dharwar
2013-04-01 8:26 ` Daniel Lezcano
2013-04-01 8:29 ` Benjamin Herrenschmidt
2013-04-02 18:37 ` Olof Johansson
2013-03-29 10:31 ` [PATCH 5/9] ARM: tegra2: cpuidle: change driver initialization Daniel Lezcano
2013-03-29 16:02 ` Stephen Warren
2013-04-03 11:18 ` Daniel Lezcano
2013-04-03 11:23 ` Joseph Lo
2013-04-03 12:09 ` Daniel Lezcano
2013-03-30 2:22 ` Joseph Lo
2013-04-03 16:51 ` Stephen Warren
2013-03-29 10:31 ` [PATCH 6/9] ARM: tegra: cpuidle: remove useless initialization Daniel Lezcano
2013-03-29 10:31 ` [PATCH 7/9] ARM: davinci: cpuidle: fix wrong enter function Daniel Lezcano
2013-03-29 11:36 ` Santosh Shilimkar
2013-03-29 10:31 ` [PATCH 8/9] intel: cpuidle: remove stop/start critical timings Daniel Lezcano
2013-03-29 10:31 ` [PATCH 9/9] ARM: omap3: cpuidle: enable time keeping Daniel Lezcano
2013-03-29 11:35 ` Santosh Shilimkar
2013-03-29 11:40 ` [PATCH 1/9] ARM: cpuidle: remove useless declaration Santosh Shilimkar
2013-03-29 11:53 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515572C7.1030309@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).