From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: keep power on to SD slot on Dalmore
Date: Fri, 29 Mar 2013 10:33:17 -0600 [thread overview]
Message-ID: <5155C24D.2000704@wwwdotorg.org> (raw)
In-Reply-To: <51552AA4.1030607@nvidia.com>
On 03/28/2013 11:46 PM, Laxman Dewangan wrote:
> On Friday 29 March 2013 12:52 AM, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards
>> work. This used to work, since this regulator is on by default, but was
>> broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that
>> didn't specify always-on for this regulator.
>>
>> In the long run, the regulators should all be hooked up to the SDHCI
>> device nodes. However, we haven't done that for any of the Tegra boards
>> yet, so to be consistent, this patch simply forces the regulator on,
>> rather than hooking it up and making it work differently to other boards.
>>
>> Cc: Laxman Dewangan <ldewangan@nvidia.com>
>> Reported-by: Rhyland Klein <rklein@nvidia.com>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
>
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
>
> This means we should keep sd slot rails always ON when we populate the
> power tree for any Tegra board?
For now yes.
Ideally, our DTs would include the appropriate supply properties in each
SDHCI/MMC node, and then everything would work out as it's supposed to.
However, that requires verification, and might be interdependent with
our SDHCI driver correctly supporting various HS modes that actively
require non-default voltages. We have a bug filed to fully flesh out and
validate the Tegra MMC driver upstream. It's assigned to Pavan. However,
I haven't seen any movement in the Tegra MMC driver area for eons:-(
Perhaps you can push on him if he's at the same site?
next prev parent reply other threads:[~2013-03-29 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 19:22 [PATCH] ARM: tegra: keep power on to SD slot on Dalmore Stephen Warren
2013-03-29 5:46 ` Laxman Dewangan
2013-03-29 16:33 ` Stephen Warren [this message]
2013-03-29 16:36 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5155C24D.2000704@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).