[PATCH] ARM: tegra: keep power on to SD slot on Dalmore

[PATCH] ARM: tegra: keep power on to SD slot on Dalmore

[Stephen Warren]

From: Stephen Warren <swarren@nvidia.com>

Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards
work. This used to work, since this regulator is on by default, but was
broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that
didn't specify always-on for this regulator.

In the long run, the regulators should all be hooked up to the SDHCI
device nodes. However, we haven't done that for any of the Tegra boards
yet, so to be consistent, this patch simply forces the regulator on,
rather than hooking it up and making it work differently to other boards.

Cc: Laxman Dewangan <ldewangan@nvidia.com>
Reported-by: Rhyland Klein <rklein@nvidia.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 arch/arm/boot/dts/tegra114-dalmore.dts |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index 2ef9f0e..0d8ceda 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -807,6 +807,7 @@
 
 				fet6 {
 					regulator-name = "vdd-sd-slot";
+					regulator-always-on;
 					regulator-boot-on;
 				};
 
-- 
1.7.10.4

[PATCH] ARM: tegra: keep power on to SD slot on Dalmore

[Laxman Dewangan]

On Friday 29 March 2013 12:52 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards
> work. This used to work, since this regulator is on by default, but was
> broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that
> didn't specify always-on for this regulator.
>
> In the long run, the regulators should all be hooked up to the SDHCI
> device nodes. However, we haven't done that for any of the Tegra boards
> yet, so to be consistent, this patch simply forces the regulator on,
> rather than hooking it up and making it work differently to other boards.
>
> Cc: Laxman Dewangan <ldewangan@nvidia.com>
> Reported-by: Rhyland Klein <rklein@nvidia.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

This means we should keep sd slot rails always ON when we populate the 
power tree for any Tegra board?

[PATCH] ARM: tegra: keep power on to SD slot on Dalmore

[Stephen Warren]

On 03/28/2013 11:46 PM, Laxman Dewangan wrote:
> On Friday 29 March 2013 12:52 AM, Stephen Warren wrote:
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Set "regulator-always-on" for the SD slot on Dalmore, so that SD cards
>> work. This used to work, since this regulator is on by default, but was
>> broken by commit "ARM: tegra: dalmore: add TPS65090 node", since that
>> didn't specify always-on for this regulator.
>>
>> In the long run, the regulators should all be hooked up to the SDHCI
>> device nodes. However, we haven't done that for any of the Tegra boards
>> yet, so to be consistent, this patch simply forces the regulator on,
>> rather than hooking it up and making it work differently to other boards.
>>
>> Cc: Laxman Dewangan <ldewangan@nvidia.com>
>> Reported-by: Rhyland Klein <rklein@nvidia.com>
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
>> ---
> 
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
> 
> This means we should keep sd slot rails always ON when we populate the
> power tree for any Tegra board?

For now yes.

Ideally, our DTs would include the appropriate supply properties in each
SDHCI/MMC node, and then everything would work out as it's supposed to.
However, that requires verification, and might be interdependent with
our SDHCI driver correctly supporting various HS modes that actively
require non-default voltages. We have a bug filed to fully flesh out and
validate the Tegra MMC driver upstream. It's assigned to Pavan. However,
I haven't seen any movement in the Tegra MMC driver area for eons:-(
Perhaps you can push on him if he's at the same site?

[PATCH] ARM: tegra: keep power on to SD slot on Dalmore

[Stephen Warren]

On 03/28/2013 01:22 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
> 
> Set "regulator-always-on" for the SD slot on Dalmore, so that SD
> cards work. This used to work, since this regulator is on by
> default, but was broken by commit "ARM: tegra: dalmore: add
> TPS65090 node", since that didn't specify always-on for this
> regulator.
> 
> In the long run, the regulators should all be hooked up to the
> SDHCI device nodes. However, we haven't done that for any of the
> Tegra boards yet, so to be consistent, this patch simply forces the
> regulator on, rather than hooking it up and making it work
> differently to other boards.

Applied to Tegra's for-3.10/dt branch.