[PATCH] ARM: davinci: remove test for undefined Kconfig macro

[PATCH] ARM: davinci: remove test for undefined Kconfig macro

[Paul Bolle]

The DaVinci debugging macro contains a check for
CONFIG_DEBUG_DAVINCI_DA8XX_UART0. But there's corresponding Kconfig
symbol, so this test will always evaluate to false. That Kconfig symbol
is not needed because, as __arch_decomp_setup() shows, there are no
DaVinci DA8XX boards that use UART0 for debugging. We can remove two
lines of unneeded code.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Untested.

1) See commit 477099f189101a6675d93782164446015a3633bd ("ARM: davinci:
implement DEBUG_LL port choice") for the introduction of this code.

 arch/arm/mach-davinci/include/mach/debug-macro.S | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/mach-davinci/include/mach/debug-macro.S b/arch/arm/mach-davinci/include/mach/debug-macro.S
index 34290d1..b18b8eb 100644
--- a/arch/arm/mach-davinci/include/mach/debug-macro.S
+++ b/arch/arm/mach-davinci/include/mach/debug-macro.S
@@ -24,8 +24,6 @@
 
 #if defined(CONFIG_DEBUG_DAVINCI_DMx_UART0)
 #define UART_BASE	DAVINCI_UART0_BASE
-#elif defined(CONFIG_DEBUG_DAVINCI_DA8XX_UART0)
-#define UART_BASE	DA8XX_UART0_BASE
 #elif defined(CONFIG_DEBUG_DAVINCI_DA8XX_UART1)
 #define UART_BASE	DA8XX_UART1_BASE
 #elif defined(CONFIG_DEBUG_DAVINCI_DA8XX_UART2)
-- 
1.7.11.7

[PATCH] ARM: davinci: remove test for undefined Kconfig macro

[Paul Bolle]

[Dropped Kevin Hilman, because Kevin's address bounces.]

On Fri, 2013-03-29 at 12:47 +0100, Paul Bolle wrote:
> The DaVinci debugging macro contains a check for
> CONFIG_DEBUG_DAVINCI_DA8XX_UART0. But there's corresponding Kconfig

                                  [...] there's no corresponding [...]

> symbol, so this test will always evaluate to false. That Kconfig symbol
> is not needed because, as __arch_decomp_setup() shows, there are no
> DaVinci DA8XX boards that use UART0 for debugging. We can remove two
> lines of unneeded code.


Paul Bolle

[PATCH] ARM: davinci: remove test for undefined Kconfig macro

[Sekhar Nori]

On 3/29/2013 6:03 PM, Paul Bolle wrote:
> [Dropped Kevin Hilman, because Kevin's address bounces.]

Use khilman at deeprootsystems.com as updated in MAINTAINERS.

> 
> On Fri, 2013-03-29 at 12:47 +0100, Paul Bolle wrote:
>> The DaVinci debugging macro contains a check for
>> CONFIG_DEBUG_DAVINCI_DA8XX_UART0. But there's corresponding Kconfig
> 
>                                   [...] there's no corresponding [...]
> 
>> symbol, so this test will always evaluate to false. That Kconfig symbol
>> is not needed because, as __arch_decomp_setup() shows, there are no
>> DaVinci DA8XX boards that use UART0 for debugging. We can remove two
>> lines of unneeded code.

Queuing this for v3.10 with updated commit text indicated above.

Thanks,
Sekhar