linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support
Date: Tue, 02 Apr 2013 15:47:18 +0400	[thread overview]
Message-ID: <515AC546.90905@cogentembedded.com> (raw)
In-Reply-To: <87wqsl6ale.wl%kuninori.morimoto.gx@renesas.com>

Hello.

On 02-04-2013 4:27, Kuninori Morimoto wrote:

>> +void __init r8a7779_add_ether_device(void *pdata)
>> +{
>> +	ether_device.dev.platform_data = pdata;
>> +
>> +	platform_device_register(&ether_device);
>> +}

> We didn't use this style of registration before,
> but, it is OK.

     Se the DU support patches, I'm copying the approach from them.

> Then, this (void *pdata) should be
> (struct sh_eth_plat_data *pdata) IMO

    ether_device.dev.platform_data is 'void *'. I didn't want to bring in 
extra header for the little use.

WBR, Sergei

  reply	other threads:[~2013-04-02 11:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-01 22:04 [PATCH 1/2] ARM: shmobile: R8A7779: add Ether support Sergei Shtylyov
2013-04-02  0:17 ` Kuninori Morimoto
2013-04-02 11:45   ` Sergei Shtylyov
2013-04-03  0:25     ` Kuninori Morimoto
2013-04-03 13:27       ` Sergei Shtylyov
2013-04-04  9:03         ` Simon Horman
2013-04-02  0:27 ` Kuninori Morimoto
2013-04-02 11:47   ` Sergei Shtylyov [this message]
2013-04-03  0:08     ` Kuninori Morimoto
2013-04-03 13:22       ` Sergei Shtylyov
2013-04-04  6:34         ` Simon Horman
2013-04-04  9:04           ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515AC546.90905@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).