linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: LPC32xx: changed lpc23xx_restart to lpc32xx_restart
@ 2013-03-06 20:18 Martin Knoll
  2013-04-02 15:58 ` Olof Johansson
  0 siblings, 1 reply; 3+ messages in thread
From: Martin Knoll @ 2013-03-06 20:18 UTC (permalink / raw)
  To: linux-arm-kernel

This function has an odd name. This is probably a typo.
---
 arch/arm/mach-lpc32xx/common.c  | 2 +-
 arch/arm/mach-lpc32xx/common.h  | 2 +-
 arch/arm/mach-lpc32xx/phy3250.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-lpc32xx/common.c b/arch/arm/mach-lpc32xx/common.c
index 0d4db8c..20c0ed7 100644
--- a/arch/arm/mach-lpc32xx/common.c
+++ b/arch/arm/mach-lpc32xx/common.c
@@ -207,7 +207,7 @@ void __init lpc32xx_map_io(void)
 	iotable_init(lpc32xx_io_desc, ARRAY_SIZE(lpc32xx_io_desc));
 }
 
-void lpc23xx_restart(char mode, const char *cmd)
+void lpc32xx_restart(char mode, const char *cmd)
 {
 	switch (mode) {
 	case 's':
diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h
index e0b2606..5d90469 100644
--- a/arch/arm/mach-lpc32xx/common.h
+++ b/arch/arm/mach-lpc32xx/common.h
@@ -29,7 +29,7 @@ extern void lpc32xx_timer_init(void);
 extern void __init lpc32xx_init_irq(void);
 extern void __init lpc32xx_map_io(void);
 extern void __init lpc32xx_serial_init(void);
-extern void lpc23xx_restart(char, const char *);
+extern void lpc32xx_restart(char, const char *);
 
 
 /*
diff --git a/arch/arm/mach-lpc32xx/phy3250.c b/arch/arm/mach-lpc32xx/phy3250.c
index c1cd5a9..16e5b58 100644
--- a/arch/arm/mach-lpc32xx/phy3250.c
+++ b/arch/arm/mach-lpc32xx/phy3250.c
@@ -266,5 +266,5 @@ DT_MACHINE_START(LPC32XX_DT, "LPC32XX SoC (Flattened Device Tree)")
 	.init_time	= lpc32xx_timer_init,
 	.init_machine	= lpc3250_machine_init,
 	.dt_compat	= lpc32xx_dt_compat,
-	.restart	= lpc23xx_restart,
+	.restart	= lpc32xx_restart,
 MACHINE_END
-- 
1.7.12.4 (Apple Git-37)

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: LPC32xx: changed lpc23xx_restart to lpc32xx_restart
  2013-03-06 20:18 [PATCH] ARM: LPC32xx: changed lpc23xx_restart to lpc32xx_restart Martin Knoll
@ 2013-04-02 15:58 ` Olof Johansson
  2013-04-02 17:43   ` Roland Stigge
  0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2013-04-02 15:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Mar 06, 2013 at 09:18:58PM +0100, Martin Knoll wrote:
> This function has an odd name. This is probably a typo.

You should cc the platform maintainer on these kind of patches (Roland Stigge).
But it seems that he's not actually listed in MAINTAINERS.

Roland, can you send a patch adding yourself as LPC32XX maintainer so these
kind of patches don't get dropped? Thanks!


-Olof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: LPC32xx: changed lpc23xx_restart to lpc32xx_restart
  2013-04-02 15:58 ` Olof Johansson
@ 2013-04-02 17:43   ` Roland Stigge
  0 siblings, 0 replies; 3+ messages in thread
From: Roland Stigge @ 2013-04-02 17:43 UTC (permalink / raw)
  To: linux-arm-kernel

On 02/04/13 17:58, Olof Johansson wrote:
> On Wed, Mar 06, 2013 at 09:18:58PM +0100, Martin Knoll wrote:
>> This function has an odd name. This is probably a typo.
> 
> You should cc the platform maintainer on these kind of patches (Roland Stigge).
> But it seems that he's not actually listed in MAINTAINERS.

I indeed missed the above patch - should be a simple syntactic fix in 3
places in arch/arm/. You can go ahead this time and directly take this
fix. Otherwise, please forward to me so I can add it to a lpc32xx tree
and do request pull.

> Roland, can you send a patch adding yourself as LPC32XX maintainer so these
> kind of patches don't get dropped? Thanks!

OK, just did.

Thanks for notifying!

Roland

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-02 17:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-06 20:18 [PATCH] ARM: LPC32xx: changed lpc23xx_restart to lpc32xx_restart Martin Knoll
2013-04-02 15:58 ` Olof Johansson
2013-04-02 17:43   ` Roland Stigge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).