linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding
Date: Thu, 4 Apr 2013 18:04:37 +0200	[thread overview]
Message-ID: <515DA495.8030205@atmel.com> (raw)
In-Reply-To: <515D7A4F.90707@interlog.com>

On 04/04/2013 03:04 PM, Douglas Gilbert :

> A pattern is emerging with sloppy at91 dts(i) files
> with pinctrls: the comments are correct and the
> corresponding encoding is wrong. The other example that
> I fixed was at91sam9x5.dtsi . Makes you wonder how many
> people are using this DT stuff in anger ...
> 
> This problem was found with AT91SAM9G20 SoCs (Acme's FoxG20).
> The attached is against lk 3.9.0-rc5 .


>  
>  					pinctrl_usart3_rts: usart3_rts-0 {
>  						atmel,pins =
> -							<3 8 0x2 0x0>;	/* PB8 periph B */
> +							<1 8 0x2 0x0>;	/* PB8 periph B */

Here both the comment and the encoding were wrong:
it is PC8 periph B ==> <2 8 0x2  0x0>

>  					};
>  
>  					pinctrl_usart3_cts: usart3_cts-0 {
>  						atmel,pins =
> -							<3 10 0x2 0x0>;	/* PB10 periph B */
> +							<1 10 0x2 0x0>;	/* PB10 periph B */

Same here:
it is PC10 periph B ==> <2 10 0x2  0x0>

>  					};
>  				};

I correct this in your patch and submit it right now.

Thanks, best regards,
-- 
Nicolas Ferre

  reply	other threads:[~2013-04-04 16:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 13:04 [PATCH] at91sam9260.dtsi: fix u(s)art pinctrl encoding Douglas Gilbert
2013-04-04 16:04 ` Nicolas Ferre [this message]
2013-04-04 16:27 ` [PATCH v2] ARM: at91/at91sam9260.dtsi: " Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515DA495.8030205@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).