From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/7] kbuild: create an "include chroot" for DT bindings
Date: Thu, 04 Apr 2013 18:17:14 -0500 [thread overview]
Message-ID: <515E09FA.1090408@gmail.com> (raw)
In-Reply-To: <1365032098-22825-1-git-send-email-swarren@wwwdotorg.org>
On 04/03/2013 06:34 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> The recent dtc+cpp support allows header files and C pre-processor
> defines/macros to be used when compiling device tree files. These
> headers will typically define various constants that are part of the
> device tree bindings.
>
> The original patch which set up the dtc+cpp include path only considered
> using those headers from device tree files. However, most are also
> useful for kernel code which needs to interpret the device tree.
>
> In both the DT files and the kernel, I'd like to include the DT-related
> headers in the same way, for example, <dt-bindings/gpio/tegra-gpio.h>.
> That will simplify any text which discusses the DT header locations.
>
> Creating a <dt-bindings/> for kernel source to use is as simple as
> placing files into include/dt-bindings/.
>
> However, when compiling DT files, the include path should be restricted
> so that only the dt-bindings path is available; arbitrary kernel headers
> shouldn't be exposed. For this reason, create a specific include
> directory for use by dtc+cpp, and symlink dt-bindings from there to the
> actual location of include/dt-bindings/. For want of a better location,
> place this "include chroot" into the existing dts/ directory.
>
> arch/*/boot/dts/include/dt-bindings -> ../../../../../include/dt-bindings
>
> Some headers used by device tree files may not be useful to the kernel;
> they may be used simply to aid in constructing the DT file (e.g. macros
> to create a node), but not define any information that the kernel needs
> to share. These may be placed directly into arch/*/boot/dts/ along with
> the DT files themselves.
>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Hiroshi Doyu <hdoyu@nvidia.com>
> Acked-by: Michal Marek <mmarek@suse.cz>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
> Acked-by: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> Grant, Rob, Michal, I'm hoping for acks or comments from you so this
> series can be placed into a topic branch in the arm-soc repo, for others
> to build on during the 3.10 kernel cycle. Thanks.
Well, you have mine here and the rest looks fine, so add it to the others.
Rob
>
> This first patch was previously posted separately as V2. I'm including
> it here to keep it with the whole series. I hope this series can be
> applied as a topic branch in arm-soc.
> ---
> arch/arm/boot/dts/include/dt-bindings | 1 +
> scripts/Makefile.lib | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
> create mode 120000 arch/arm/boot/dts/include/dt-bindings
>
> diff --git a/arch/arm/boot/dts/include/dt-bindings b/arch/arm/boot/dts/include/dt-bindings
> new file mode 120000
> index 0000000..08c00e4
> --- /dev/null
> +++ b/arch/arm/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 07125e6..af35521 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -158,7 +158,7 @@ ld_flags = $(LDFLAGS) $(ldflags-y)
>
> dtc_cpp_flags = -Wp,-MD,$(depfile) -nostdinc \
> -I$(srctree)/arch/$(SRCARCH)/boot/dts \
> - -I$(srctree)/arch/$(SRCARCH)/include/dts \
> + -I$(srctree)/arch/$(SRCARCH)/boot/dts/include \
> -undef -D__DTS__
>
> # Finds the multi-part object the current object will be linked into
>
next prev parent reply other threads:[~2013-04-04 23:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 23:34 [PATCH V2 1/7] kbuild: create an "include chroot" for DT bindings Stephen Warren
2013-04-03 23:34 ` [PATCH V2 2/7] kbuild: fixdep: support concatenated dep files Stephen Warren
2013-04-03 23:34 ` [PATCH V2 3/7] kbuild: cmd_dtc_cpp: extract deps from both gcc -E and dtc Stephen Warren
2013-04-03 23:34 ` [PATCH V2 4/7] kbuild: always run gcc -E on *.dts, remove cmd_dtc_cpp Stephen Warren
2013-04-04 0:02 ` Emilio López
2013-04-04 16:41 ` Stephen Warren
2013-04-03 23:34 ` [PATCH V2 5/7] ARM: dt: add header to define GPIO flags Stephen Warren
2013-04-03 23:34 ` [PATCH V2 6/7] ARM: dt: add header to define IRQ flags Stephen Warren
2013-04-03 23:34 ` [PATCH V2 7/7] ARM: dt: create a DT header for the GIC Stephen Warren
2013-04-04 23:17 ` Rob Herring [this message]
2013-04-05 1:01 ` [PATCH V2 1/7] kbuild: create an "include chroot" for DT bindings Stephen Warren
2013-04-05 16:06 ` Rob Herring
2013-04-19 10:01 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515E09FA.1090408@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).