From: <Tudor.Ambarus@microchip.com>
To: <Claudiu.Beznea@microchip.com>, <Nicolas.Ferre@microchip.com>
Cc: <alexandre.belloni@bootlin.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <Mihai.Sain@microchip.com>
Subject: Re: [PATCH] ARM: dts: at91: sama7g5ek: Align the impedance of the QSPI0's HSIO and PCB lines
Date: Thu, 7 Apr 2022 07:51:24 +0000 [thread overview]
Message-ID: <515d14f2-1a3f-1bfe-93e7-2baafc45ce4f@microchip.com> (raw)
In-Reply-To: <8f778b95-d68e-6575-ff8b-f1dd8d4d8777@microchip.com>
On 4/7/22 09:26, Claudiu Beznea - M18063 wrote:
> Hi, Tudor,
>
> On 06.04.2022 16:05, Tudor Ambarus wrote:
>> The impedance of the QSPI PCB lines on the sama7g5ek is 50 Ohms.
>> Align the output impedance of the QSPI0 HSIOs by setting a medium drive
>> strength which corresponds to an impedance of 56 Ohms when VDD is in the
>> 3.0V - 3.6V range. The high drive strength setting corresponds to an
>> output impedance of 42 Ohms on the QSPI0 HSIOs.
>>
>> Suggested-by: Mihai Sain <mihai.sain@microchip.com>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Is it necessary a fixes tag here?
>
It's not a fix per se, it's just a fine tuning that's why I chose to don't add
the fixes tag. The memory that we have populated on sama7g5ek works fine even
with high drive strength, but it's better to adjust it and use medium instead,
in case some other flashes with higher frequencies are tested. If you think a
fixes tag is needed, give me a sign and I'll resubmit.
>
>> ---
>> arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama7g5ek.dts b/arch/arm/boot/dts/at91-sama7g5ek.dts
>> index 08685a10eda1..8f9643170ba3 100644
>> --- a/arch/arm/boot/dts/at91-sama7g5ek.dts
>> +++ b/arch/arm/boot/dts/at91-sama7g5ek.dts
>> @@ -655,7 +655,7 @@ pinctrl_qspi: qspi {
>> <PIN_PB21__QSPI0_INT>;
>> bias-disable;
>> slew-rate = <0>;
>> - atmel,drive-strength = <ATMEL_PIO_DRVSTR_HI>;
>> + atmel,drive-strength = <ATMEL_PIO_DRVSTR_ME>;
>> };
>>
>> pinctrl_sdmmc0_default: sdmmc0_default {
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-07 7:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 13:05 [PATCH] ARM: dts: at91: sama7g5ek: Align the impedance of the QSPI0's HSIO and PCB lines Tudor Ambarus
2022-04-07 6:26 ` Claudiu.Beznea
2022-04-07 7:51 ` Tudor.Ambarus [this message]
2022-04-07 8:24 ` Claudiu.Beznea
2022-04-13 12:40 ` Nicolas Ferre
2022-04-13 12:43 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515d14f2-1a3f-1bfe-93e7-2baafc45ce4f@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).