linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: panand@redhat.com (Pratyush Anand)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] interrupted single step fixes
Date: Fri, 4 Aug 2017 18:19:20 +0530	[thread overview]
Message-ID: <515dfb90-5313-fe6c-673b-a25da43e186e@redhat.com> (raw)
In-Reply-To: <20170803151533.29438-1-james.morse@arm.com>

Hi James,

Thanks a lot for looking into it.

On Thursday 03 August 2017 08:45 PM, James Morse wrote:
> Enable CONFIG_SAMPLE_HW_BREAKPOINT, then:
>> insmod data_breakpoint.ko ksym=__sysrq_enabled
>> cat /proc/sys/kernel/sysrq
> With mainline you will hit the watchpoint forever, Pratyush's patches
> reduce this to ~10 times. These patches reduce that to the expected
> once.

So, when you say that it reduce to ~10 times with my patches, did you use all 
patches ie 1-4 or only 1-3. 1-3 is just the preparation and 4 was my actual 
solution. I had seen only once (which is expected) with all(1-4) of my 
patches. Please let me know if I missed any observation.

In my understanding, you have used 1-3 of mine and then replaced my 4th patch 
with your patches in this series.If I understood correctly then, now we can 
handle IRQ between breakpoint and step handler, I think thats good. Only 
concern seems that how does this approach behave when we put a hardware 
breakpoint on a ISR called between breakpoint and step exception.


-- 
Regards
Pratyush

  parent reply	other threads:[~2017-08-04 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03 15:15 [PATCH 0/3] interrupted single step fixes James Morse
2017-08-03 15:15 ` [PATCH 1/3] arm64: entry: Allow SPSR_EL1.SS to be restored James Morse
2017-08-03 15:15 ` [PATCH 2/3] kernel: debug-monitors: Disable preemption James Morse
2017-08-03 15:15 ` [PATCH 3/3] arm64: entry: Exceptions from single-step should leave debug masked James Morse
2017-08-04 12:49 ` Pratyush Anand [this message]
2017-08-04 16:57   ` [PATCH 0/3] interrupted single step fixes James Morse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=515dfb90-5313-fe6c-673b-a25da43e186e@redhat.com \
    --to=panand@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).