linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: illia.ragozin@grapecom.com (Elijah Ragozin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v2 1/1] ARM Feroceon: fix kexec by setting outer_cache.inv_all
Date: Mon, 08 Apr 2013 22:34:07 +0300	[thread overview]
Message-ID: <51631BAF.40408@grapecom.com> (raw)
In-Reply-To: <51631B12.2010908@grapecom.com>

On Feroceon the L2 cache becomes non-coherent with the CPU
when the L1 caches are disabled. Thus the L2 needs to be invalidated
after both L1 caches are disabled.

On kexec before the starting the code for relocation the kernel,
the L1 caches are disabled in cpu_froc_fin (cpu_v7_proc_fin for Feroceon),
but after L2 cache is never invalidated, because inv_all is not set
in cache-feroceon-l2.c.
So kernel relocation and decompression may has (and usually has) errors.
Setting the function enables L2 invalidation and fixes the issue.

Signed-off-by: Illia Ragozin <illia.ragozin@grapecom.com>
---
  arch/arm/mm/cache-feroceon-l2.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/arm/mm/cache-feroceon-l2.c
b/arch/arm/mm/cache-feroceon-l2.c
index e0b0e7a..09f8851 100644
--- a/arch/arm/mm/cache-feroceon-l2.c
+++ b/arch/arm/mm/cache-feroceon-l2.c
@@ -342,6 +342,7 @@ void __init feroceon_l2_init(int __l2_wt_override)
  	outer_cache.inv_range = feroceon_l2_inv_range;
  	outer_cache.clean_range = feroceon_l2_clean_range;
  	outer_cache.flush_range = feroceon_l2_flush_range;
+	outer_cache.inv_all = l2_inv_all;
  
  	enable_l2();
  
-- 
1.8.1.4

  reply	other threads:[~2013-04-08 19:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 19:43 [PATCH v2 1/1] ARM Feroceon: fix kexec by setting outer_cache.inv_all Elijah Ragozin
2013-04-08 19:31 ` Fwd: [PATCH RESEND " Elijah Ragozin
2013-04-08 19:34   ` Elijah Ragozin [this message]
2013-04-10 16:48     ` Jason Cooper
2013-04-10 18:42       ` Elijah Ragozin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51631BAF.40408@grapecom.com \
    --to=illia.ragozin@grapecom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).