From: daniel.lezcano@free.fr (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/18] ARM: tegra2: cpuidle: use init/exit common routine
Date: Thu, 11 Apr 2013 07:58:26 +0200 [thread overview]
Message-ID: <51665102.10301@free.fr> (raw)
In-Reply-To: <1365642100.1806.5.camel@jlo-ubuntu-64.nvidia.com>
On 04/11/2013 03:01 AM, Joseph Lo wrote:
> On Wed, 2013-04-10 at 22:22 +0800, Daniel Lezcano wrote:
>> Remove the duplicated code and use the cpuidle common code for initialization.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---
>> arch/arm/mach-tegra/cpuidle-tegra20.c | 33 +--------------------------------
>> 1 file changed, 1 insertion(+), 32 deletions(-)
>>
>> diff --git a/arch/arm/mach-tegra/cpuidle-tegra20.c b/arch/arm/mach-tegra/cpuidle-tegra20.c
>> index f1f6ac4..d6c2ba6 100644
>> --- a/arch/arm/mach-tegra/cpuidle-tegra20.c
>> +++ b/arch/arm/mach-tegra/cpuidle-tegra20.c
>> @@ -70,8 +70,6 @@ static struct cpuidle_driver tegra_idle_driver = {
>> .safe_state_index = 0,
>> };
>>
>> -static DEFINE_PER_CPU(struct cpuidle_device, tegra_idle_device);
>> -
>> #ifdef CONFIG_PM_SLEEP
>> #ifdef CONFIG_SMP
>> static void __iomem *pmc = IO_ADDRESS(TEGRA_PMC_BASE);
>> @@ -220,34 +218,5 @@ static int tegra20_idle_lp2_coupled(struct cpuidle_device *dev,
>>
>> int __init tegra20_cpuidle_init(void)
>> {
>> - int ret;
>> - unsigned int cpu;
>> - struct cpuidle_device *dev;
>> - struct cpuidle_driver *drv = &tegra_idle_driver;
>> -
>> -#ifdef CONFIG_PM_SLEEP
>> - tegra_tear_down_cpu = tegra20_tear_down_cpu;
>> -#endif
> Hi Daniel,
>
> Please keep these 3 lines above, just like you did for Tegra30.
>
> Thanks,
> Joseph
Oups, thanks !
-- Daniel
next prev parent reply other threads:[~2013-04-11 5:58 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 14:22 [PATCH 00/18] cpuidle: code consolidation Daniel Lezcano
2013-04-10 14:22 ` [PATCH 01/18] ARM: OMAP3: remove cpuidle_wrap_enter Daniel Lezcano
2013-04-10 14:22 ` [PATCH 02/18] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-10 14:22 ` [PATCH 03/18] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-10 14:22 ` [PATCH 04/18] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Daniel Lezcano
2013-04-12 6:05 ` Shawn Guo
2013-04-12 6:58 ` Daniel Lezcano
2013-04-12 7:11 ` Shawn Guo
2013-04-12 7:12 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 05/18] cpuidle: make a single register function for all Daniel Lezcano
2013-04-10 14:59 ` Rob Herring
2013-04-10 15:05 ` Daniel Lezcano
2013-04-22 6:57 ` Daniel Lezcano
2013-04-10 16:55 ` Andrew Lunn
2013-04-10 18:04 ` Daniel Lezcano
2013-04-10 18:18 ` Andrew Lunn
2013-04-10 22:07 ` Daniel Lezcano
2013-04-10 17:04 ` Andrew Lunn
2013-04-10 18:02 ` Daniel Lezcano
2013-04-10 18:23 ` Andrew Lunn
2013-04-10 19:59 ` Daniel Lezcano
2013-04-10 18:22 ` Colin Cross
2013-04-10 19:59 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 06/18] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-10 14:22 ` [PATCH 07/18] ARM: at91: " Daniel Lezcano
2013-04-10 14:39 ` Nicolas Ferre
2013-04-10 14:22 ` [PATCH 08/18] ARM: OMAP3: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 09/18] ARM: s3c64xx: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 10/18] ARM: tegra1: " Daniel Lezcano
2013-04-10 17:29 ` Stephen Warren
2013-04-10 18:05 ` Daniel Lezcano
2013-04-10 14:22 ` [PATCH 11/18] ARM: shmobile: " Daniel Lezcano
2013-04-11 2:46 ` Simon Horman
2013-04-10 14:22 ` [PATCH 12/18] ARM: OMAP4: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 13/18] ARM: tegra2: " Daniel Lezcano
2013-04-11 1:01 ` Joseph Lo
2013-04-11 5:58 ` Daniel Lezcano [this message]
2013-04-10 14:22 ` [PATCH 14/18] ARM: tegra3: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 15/18] ARM: calxeda: " Daniel Lezcano
2013-04-10 14:31 ` Rob Herring
2013-04-10 14:22 ` [PATCH 16/18] ARM: kirkwood: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 17/18] ARM: davinci: " Daniel Lezcano
2013-04-10 14:22 ` [PATCH 18/18] ARM: imx: " Daniel Lezcano
2013-04-10 19:12 ` [PATCH 00/18] cpuidle: code consolidation Rafael J. Wysocki
2013-04-10 20:01 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51665102.10301@free.fr \
--to=daniel.lezcano@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).