linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: rklein@nvidia.com (Rhyland Klein)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: Add charger subnode to tps65090 node
Date: Thu, 11 Apr 2013 11:38:47 -0400	[thread overview]
Message-ID: <5166D907.6060004@nvidia.com> (raw)
In-Reply-To: <5165E80D.7050106@wwwdotorg.org>

On 4/10/2013 6:30 PM, Stephen Warren wrote:
> On 04/10/2013 01:51 PM, Rhyland Klein wrote:
>> The charger is now represented by a distinct subnode of the tps65090
>> device. Add this node and enable low current charging with it.
> 
>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> 
>> +			charger {
>> +				compatible = "ti,tps65090-charger";
>> +				ti,enable-low-current-chrg;
> 
> So does the TPS65090 driver scan all its sub-nodes like a bus an
> instantiate anything? That's a little odd since the regulators node is
> at the same level, yet doesn't represent a device on that same internal
> bus...
> 

It doesn't scan so much as have a list of subdev's it tries to register.
The charger node uses the of_compatible string defined (in the tps65090
driver and the charger driver) to match the subnode to the mfd_cell
device for the charger. The regulators are currently under a different
subdevice which is not using the of_compatible string. I was planning on
a follow up patch series to update the tps65090-regulator driver to use
the dt type approach with a subnode to be consistent.

-rhyland

-- 
nvpublic

  reply	other threads:[~2013-04-11 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-10 19:51 [PATCH] ARM: tegra: Add charger subnode to tps65090 node Rhyland Klein
2013-04-10 22:30 ` Stephen Warren
2013-04-11 15:38   ` Rhyland Klein [this message]
2013-04-11 16:17     ` Stephen Warren
2013-04-11 16:27       ` Rhyland Klein
2013-05-17 23:57 ` Stephen Warren
2013-05-20 15:24   ` Rhyland Klein
2013-05-20 15:28     ` Stephen Warren
2013-05-20 15:35       ` Rhyland Klein
2013-05-20 19:15         ` Stephen Warren
2013-05-20 20:45           ` Rhyland Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5166D907.6060004@nvidia.com \
    --to=rklein@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).