From mboxrd@z Thu Jan 1 00:00:00 1970 From: eduardo.valentin@ti.com (Eduardo Valentin) Date: Thu, 11 Apr 2013 12:29:22 -0400 Subject: [v2, 04/14] thermal: mvebu: Remove unneeded variable initialization In-Reply-To: <1363991114-4225-5-git-send-email-ezequiel.garcia@free-electrons.com> References: <1363991114-4225-5-git-send-email-ezequiel.garcia@free-electrons.com> Message-ID: <5166E4E2.1080606@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Rui, Ezequiel, On 22-03-2013 18:25, Ezequiel Garcia wrote: > This variable is used only after it's properly initialized, > so there's no need to set it to NULL in its declaration. > > Signed-off-by: Ezequiel Garcia > I am fine with this patch. Though it doesn t hurt to have this initialization, the code looks cleaner though. Acked-by: Eduardo Valentin > --- > drivers/thermal/mvebu_thermal.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/thermal/mvebu_thermal.c b/drivers/thermal/mvebu_thermal.c > index 031f94d..1f502ed 100644 > --- a/drivers/thermal/mvebu_thermal.c > +++ b/drivers/thermal/mvebu_thermal.c > @@ -72,7 +72,7 @@ MODULE_DEVICE_TABLE(of, mvebu_thermal_id_table); > > static int mvebu_thermal_probe(struct platform_device *pdev) > { > - struct thermal_zone_device *thermal = NULL; > + struct thermal_zone_device *thermal; > struct mvebu_thermal_priv *priv; > struct resource *res; > >