From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [V2 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi function
Date: Fri, 12 Apr 2013 09:11:33 +0200 [thread overview]
Message-ID: <5167B3A5.60408@linaro.org> (raw)
In-Reply-To: <20130412070619.GA21350@verge.net.au>
On 04/12/2013 09:06 AM, Simon Horman wrote:
> On ?, 4? 12, 2013 at 08:47:13?? +0200, Daniel Lezcano wrote:
>> On 04/12/2013 02:44 AM, Simon Horman wrote:
>>> On Thu, Apr 11, 2013 at 10:42:31PM +0200, Daniel Lezcano wrote:
>>>> Remove the shmobile_enter_wfi function which is the same as the
>>>> common WFI enter function from the arm cpuidle driver defined
>>>> with the ARM_CPUIDLE_WFI_STATE macro.
>>> Should this patch also make shmobile_enter_wfi static in
>>> arch/arm/mach-shmobile/cpuidle.c ?
>>
>> Hum, no :)
>
> Ok, that was my other idea :^)
>
>> Actually, the function was removed because it was expected to be not
>> longer used. I missed the cpuidle driver in the pm-sh7372.c file and the
>> function declaration in the header file.
>>> Also, I have a slight preference for the patch to be split into two.
>>> 1. A patch to remove usage of shmobile_enter_wfi from the sh7372 SoC.
>>> 2. A patch to remove shmobile_enter_wfi. from common.h
>>> (and make it static?).
>>
>> Ok, regarding my answer above, do you still want two patches for this ?
>
> Yes please.
Ok, thanks for the review.
-- Daniel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-04-12 7:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 20:42 [V2 patch 00/19] cpuidle: code consolidation Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 01/19] ARM: shmobile: cpuidle: remove shmobile_enter_wfi function Daniel Lezcano
2013-04-12 0:44 ` Simon Horman
2013-04-12 6:47 ` Daniel Lezcano
2013-04-12 7:06 ` Simon Horman
2013-04-12 7:11 ` Daniel Lezcano [this message]
2013-04-11 20:42 ` [V2 patch 02/19] ARM: OMAP3: remove cpuidle_wrap_enter Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 03/19] cpuidle: remove en_core_tk_irqen flag Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 04/19] ARM: ux500: cpuidle: replace for_each_online_cpu by for_each_possible_cpu Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 05/19] ARM: imx: cpuidle: create separate drivers for imx5/imx6 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 06/19] cpuidle: make a single register function for all Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 07/19] ARM: ux500: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 08/19] ARM: at91: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 09/19] ARM: OMAP3: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 10/19] ARM: s3c64xx: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 11/19] ARM: tegra: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 12/19] ARM: shmobile: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 13/19] ARM: OMAP4: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 14/19] ARM: tegra: cpuidle: use init/exit common routine for tegra2 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 15/19] ARM: tegra: cpuidle: use init/exit common routine for tegra3 Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 16/19] ARM: calxeda: cpuidle: use init/exit common routine Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 17/19] ARM: kirkwood: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 18/19] ARM: davinci: " Daniel Lezcano
2013-04-11 20:42 ` [V2 patch 19/19] ARM: imx: " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5167B3A5.60408@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).