linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v11 1/3] ARM: Add base support for ARMv7-M
Date: Wed, 17 Apr 2013 13:40:07 -0700	[thread overview]
Message-ID: <516F08A7.8030009@codeaurora.org> (raw)
In-Reply-To: <20130417202842.GS30416@pengutronix.de>

On 04/17/13 13:28, Uwe Kleine-K?nig wrote:
> Hello Stephen,
>
> On Wed, Apr 17, 2013 at 01:09:15PM -0700, Stephen Boyd wrote:
>> On 04/17/13 09:14, Uwe Kleine-K?nig wrote:
>>> +__v7m_proc_info:
>>> +	.long	0x000f0000		@ Required ID value
>>> +	.long	0x000f0000		@ Mask for ID
>>> +	.long   0			@ proc_info_list.__cpu_mm_mmu_flags
>>> +	.long   0			@ proc_info_list.__cpu_io_mmu_flags
>>> +	b	__v7m_setup		@ proc_info_list.__cpu_flush
>>> +	.long	cpu_arch_name
>>> +	.long	cpu_elf_name
>>> +	.long	HWCAP_HALF|HWCAP_THUMB|HWCAP_FAST_MULT|HWCAP_IDIVT
>> Mainline is detecting HWCAP_IDIVT for v7 processors so you should be
>> able to leave that part out.
> I cannot confirm that. If I drop HWCAP_IDIVT here, /proc/cpuinfo changes
> as follows:
>
> -Features	: half thumb fastmult idivt 
> +Features	: half thumb fastmult
>
> Maybe I missed to call the respective function to autodetect that? I
> don't consider that an issue big enough to justify another round for
> this series. For me letting v11 hit mainline and fix detection later is
> ok. I'll take a note to look into this, but if you want to come up with
> a patch, don't hesitate :-)

The patch that introduces the detection is
8164f7af88d9ad3a757bd14f634b23997ee77f6b. Sorry I should have read this
patch more closely. I seem to recall that M profile doesn't have the
CPUID registers in a coprocessor so it won't work. Probably easier to
leave it as is for now.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2013-04-17 20:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17 16:14 [PATCH v11 0/3] Another round of ARMv7-M patches Uwe Kleine-König
2013-04-17 16:14 ` [PATCH v11 1/3] ARM: Add base support for ARMv7-M Uwe Kleine-König
2013-04-17 19:05   ` Russell King - ARM Linux
2013-04-17 20:09   ` Stephen Boyd
2013-04-17 20:28     ` Uwe Kleine-König
2013-04-17 20:40       ` Stephen Boyd [this message]
2013-04-17 16:14 ` [PATCH v11 2/3] ARM: ARMv7-M: Add support for exception handling Uwe Kleine-König
2013-04-17 16:14 ` [PATCH v11 3/3] ARM: ARMv7-M: Allow the building of new kernel port Uwe Kleine-König
2013-04-17 17:41 ` [PATCH v11 0/3] Another round of ARMv7-M patches Jonathan Austin
2013-04-17 19:37   ` Uwe Kleine-König
2013-04-18 14:10     ` Jonathan Austin
2013-04-17 19:08 ` Russell King - ARM Linux
2013-04-17 19:30   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516F08A7.8030009@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).