From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Fri, 19 Apr 2013 15:44:46 +0400 Subject: [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code In-Reply-To: <20130419021755.GF25718@verge.net.au> References: <201304050257.00799.sergei.shtylyov@cogentembedded.com> <20130418154425.GZ14496@n2100.arm.linux.org.uk> <5170301B.3030306@cogentembedded.com> <20130419021755.GF25718@verge.net.au> Message-ID: <51712E2E.8040105@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 19-04-2013 6:17, Simon Horman wrote: >>>> +/* USB PHY */ >>>> +static struct resource usb_phy_resources[] = { >>>> + [0] = { >>>> + .start = 0xffe70000, >>>> + .end = 0xffe70900 - 1, >>>> + .flags = IORESOURCE_MEM, >>>> + }, >>>> + [1] = { >>>> + .start = 0xfff70000, >>>> + .end = 0xfff70900 - 1, >>>> + .flags = IORESOURCE_MEM, >>>> + }, >>> Please consider using the macros for these initialisers. >> I'm just moving the code as is here. The destination file still >> uses old style initializers, and probably needs the wholesale >> conversion patch in the future. > My preference is for you to either convert these users in this patch or > provide a patch that makes a wholesale conversion. I'll try to do the latter but my load is currently very high, so that may take some time. WBR, Sergei