linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support
Date: Sat, 20 Apr 2013 04:10:45 +0400	[thread overview]
Message-ID: <5171DD05.6020400@cogentembedded.com> (raw)
In-Reply-To: <201304200232.33731.sergei.shtylyov@cogentembedded.com>

Hello.

On 04/20/2013 02:32 AM, Sergei Shtylyov wrote:

> From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>
> Add VIN clocks and platform devices for R8A7779 SoC; add function to register
> the VIN platform devices.
>
> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> [Sergei: added 'id' parameter check to r8a7779_add_vin_device(), renamed some
> variables.]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

[...]

> Index: renesas/arch/arm/mach-shmobile/setup-r8a7779.c
> ===================================================================
> --- renesas.orig/arch/arm/mach-shmobile/setup-r8a7779.c
> +++ renesas/arch/arm/mach-shmobile/setup-r8a7779.c
> @@ -559,6 +559,33 @@ static struct resource ether_resources[]
>   	},
>   };
>   
> +#define R8A7779_VIN(idx) \
> +static struct resource vin##idx##_resources[] = {		\
> +	DEFINE_RES_MEM(0xffc50000 + 0x1000 * (idx), 0x1000),	\
> +	DEFINE_RES_IRQ(gic_iid(0x5f + (idx))),			\
> +};								\
> +								\
> +static struct platform_device_info vin##idx##_info = {		\

    Hm, probably should have marked this as '__initdata'... maybe
the resources too.

> +	.parent		= &platform_bus,			\
> +	.name		= "rcar_vin",				\
> +	.id		= idx,					\
> +	.res		= vin##idx##_resources,			\
> +	.num_res	= ARRAY_SIZE(vin##idx##_resources),	\
> +	.dma_mask	= DMA_BIT_MASK(32),			\
> +}
>

  reply	other threads:[~2013-04-20  0:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 22:32 [PATCH v2 2/4] ARM: shmobile: r8a7779: add VIN support Sergei Shtylyov
2013-04-20  0:10 ` Sergei Shtylyov [this message]
2013-04-22  4:57   ` Simon Horman
2013-04-22 12:37     ` Sergei Shtylyov
2013-04-23  1:19       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5171DD05.6020400@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).