From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bsp: add SoC device to brcmstb
Date: Fri, 26 Feb 2016 21:32:21 +0100 [thread overview]
Message-ID: <5174855.MZxnsKaRHh@wuerfel> (raw)
In-Reply-To: <56D09B2B.8090805@gmail.com>
On Friday 26 February 2016 10:36:27 Florian Fainelli wrote:
> On 26/02/16 05:58, Arnd Bergmann wrote:
> > On Thursday 25 February 2016 16:19:07 Justin Chen wrote:
> >> */
> >> void brcmstb_biuctrl_init(void);
> >>
> >> +/*
> >> + * Helper functions for getting family or product id from the
> >> + * SoC driver.
> >> + */
> >> +u32 brcmstb_get_family_id(void);
> >> +u32 brcmstb_get_product_id(void);
> >> +
> >> #endif /* __BRCMSTB_SOC_H */
> >> --
> >
> > Please remove the declarations from the header file and make the
> > variable local to this file, to make sure no other driver accidentally
> > accesses them.
>
> I would remove these two helper functions completely, we do not need
> them right now in an upstream kernel, if we ever need them, we could add
> them back, but we have no use for these two now.
Ok, that sounds even better.
Arnd
prev parent reply other threads:[~2016-02-26 20:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 0:19 [PATCH] bsp: add SoC device to brcmstb Justin Chen
2016-02-26 13:58 ` Arnd Bergmann
2016-02-26 18:36 ` Florian Fainelli
2016-02-26 20:32 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5174855.MZxnsKaRHh@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox