From mboxrd@z Thu Jan 1 00:00:00 1970 From: nschichan@freebox.fr (Nicolas Schichan) Date: Mon, 22 Apr 2013 14:31:20 +0200 Subject: [PATCH V2 1/3] seccomp: add generic code for jitted seccomp filters. In-Reply-To: <20130417145628.88058f0f3104ab9ae551ddd3@linux-foundation.org> References: <1363618233-6375-1-git-send-email-nschichan@freebox.fr> <1363618233-6375-2-git-send-email-nschichan@freebox.fr> <20130417145628.88058f0f3104ab9ae551ddd3@linux-foundation.org> Message-ID: <51752D98.8070709@freebox.fr> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/17/2013 11:56 PM, Andrew Morton wrote: > This patch is killing me. > >> --- a/include/linux/seccomp.h >> +++ b/include/linux/seccomp.h >> @@ -6,6 +6,7 @@ >> #ifdef CONFIG_SECCOMP >> >> #include >> +#include >> #include > > In file included from include/linux/compat.h:18, > from include/linux/filter.h:9, > from include/linux/seccomp.h:9, > from include/linux/sched.h:39, > from arch/x86/kernel/asm-offsets.c:9: > /usr/src/25/arch/x86/include/asm/compat.h: In function 'arch_compat_alloc_user_space': > /usr/src/25/arch/x86/include/asm/compat.h:301: error: dereferencing pointer to incomplete type > > Problem is, compat.h's arch_compat_alloc_user_space() needs sched.h for > task_struct but as you can see from the above include tree, sched.h > includes seccomp.h and everything falls over. The preprocessed code > contains the definition of arch_compat_alloc_user_space() *before* the > definition of task_struct. > > This is a basic x86_64 "make clean; make allmodconfig; make". Hi, Would including instead of in seccomp.h be an acceptable solution ? I have tried that and (with an additional forward declaration of struct sk_buff) an x86_64 "make clean; make allmodconfig" run finishes succesfully. If that's ok with you, I can resend the serie with that fix. Regards, -- Nicolas Schichan Freebox SAS