linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code
Date: Mon, 22 Apr 2013 17:34:05 +0400	[thread overview]
Message-ID: <51753C4D.4080701@cogentembedded.com> (raw)
In-Reply-To: <20130422010917.GC15680@verge.net.au>

Hello.

On 22-04-2013 5:09, Simon Horman wrote:

>>> USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and
>>> registered in the Marzen board file.  Move the data and code to their proper
>>> place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[]
>>> to 8a7779_standard_devices[] -- this seems legitimate since they are registered
>>
>>      I've been pointed to the types in the above variable names privately.
>> Don't know should I resend or Simon could fix s/8a7779/r8a7779/ while
>> applying... well, the USB patches haven't been ACK'ed yet.

> I can fix that up.

> Is the series waiting on anything?

    Probably on Felipe's ACKs on rcar-phy.c patches... Felipe hasn't appeared 
on this list for a week but I see his mails from today.

>> >from r8a7779_add_standard_devices() anyway.

>>> Note that I'm deliberately changing the USB PHY platform device's 'id' field
>> >from (previously just omitted) 0 to -1 as the device is a single of its kind.

>>> Note also that the board and SoC code have to be in one patch to keep the code
>>> bisectable...

>>> The patch has been tested on the Marzen board.

>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>>> Acked-by: Simon Horman <horms+renesas@verge.net.au>

WBR, Sergei

  reply	other threads:[~2013-04-22 13:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 21:56 [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code Sergei Shtylyov
2013-04-21 19:19 ` Sergei Shtylyov
2013-04-22  1:09   ` Simon Horman
2013-04-22 13:34     ` Sergei Shtylyov [this message]
2013-04-23  1:52       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51753C4D.4080701@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).