From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpuidle: add maintainer entry
Date: Wed, 24 Apr 2013 12:50:00 -0500 [thread overview]
Message-ID: <51781B48.30208@gmail.com> (raw)
In-Reply-To: <1366810463-17495-1-git-send-email-daniel.lezcano@linaro.org>
On 04/24/2013 08:34 AM, Daniel Lezcano wrote:
> Currently the cpuidle drivers are spread across the different archs.
>
> The patch submission for cpuidle are following different path: the cpuidle core
> code goes to linux-pm, the ARM drivers goes to arm-soc or the SoC specific
> tree, sh goes through sh arch tree, pseries goes through PowerPC and
> finally intel goes through Len's tree while acpi_idle goes under linux-pm.
>
> That makes difficult to consolidate the code and to propagate modifications
> from the cpuidle core to the different drivers.
>
> Hopefully, a movement has initiated to put the cpuidle drivers into the
> drivers/cpuidle directory like cpuidle-calxeda.c and cpuidle-kirkwood.c
>
> Add an explicit maintainer entry in the MAINTAINER to clarify the situation
> and prevent new cpuidle drivers to goes to an arch directory.
>
> The upstreaming process is unchanged: Rafael takes the patches to merge them
> into its tree but with the acked-by from the driver's maintainer. So the header
> must contains the name of the maintainer.
Shouldn't MAINTAINERS contain the driver maintainers too?
>
> This organization will be the same than cpufreq.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> MAINTAINERS | 7 +++++++
> drivers/cpuidle/cpuidle-calxeda.c | 4 +++-
> drivers/cpuidle/cpuidle-kirkwood.c | 5 +++--
> 3 files changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 61677c3..effa0f3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2206,6 +2206,13 @@ S: Maintained
> F: drivers/cpufreq/
> F: include/linux/cpufreq.h
>
> +CPUIDLE DRIVERS
> +M: Rafael J. Wysocki <rjw@sisk.pl>
> +L: linux-pm at vger.kernel.org
> +S: Maintained
> +F: drivers/cpuidle/*
> +F: include/linux/cpuidle.h
> +
> CPU FREQUENCY DRIVERS - ARM BIG LITTLE
> M: Viresh Kumar <viresh.kumar@linaro.org>
> M: Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
> diff --git a/drivers/cpuidle/cpuidle-calxeda.c b/drivers/cpuidle/cpuidle-calxeda.c
> index e344b56..2378c39 100644
> --- a/drivers/cpuidle/cpuidle-calxeda.c
> +++ b/drivers/cpuidle/cpuidle-calxeda.c
> @@ -1,7 +1,6 @@
> /*
> * Copyright 2012 Calxeda, Inc.
> *
> - * Based on arch/arm/plat-mxc/cpuidle.c:
This file may have moved, but it existed at the time this was committed.
So the comment still applies and documents what part of the file the FSL
and Linaro copyright applies to.
Of course most of what was copied here was the boilerplate which your
patch series removes. The heart of the functionality was developed by me.
> * Copyright 2012 Freescale Semiconductor, Inc.
> * Copyright 2012 Linaro Ltd.
> *
> @@ -16,6 +15,9 @@
> *
> * You should have received a copy of the GNU General Public License along with
> * this program. If not, see <http://www.gnu.org/licenses/>.
> + *
> + * Author : Rob Herring <rob.herring@calxeda.com>
> + * Maintainer: Rob Herring <rob.herring@calxeda.com>
As mentioned above, this doesn't seem right.
Rob
> */
>
> #include <linux/cpuidle.h>
> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
> index 53290e1..521b0a7 100644
> --- a/drivers/cpuidle/cpuidle-kirkwood.c
> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
> @@ -1,6 +1,4 @@
> /*
> - * arch/arm/mach-kirkwood/cpuidle.c
> - *
> * CPU idle Marvell Kirkwood SoCs
> *
> * This file is licensed under the terms of the GNU General Public
> @@ -11,6 +9,9 @@
> * to implement two idle states -
> * #1 wait-for-interrupt
> * #2 wait-for-interrupt and DDR self refresh
> + *
> + * Maintainer: Jason Cooper <jason@lakedaemon.net>
> + * Maintainer: Andrew Lunn <andrew@lunn.ch>
> */
>
> #include <linux/kernel.h>
>
next prev parent reply other threads:[~2013-04-24 17:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 13:34 [PATCH] cpuidle: add maintainer entry Daniel Lezcano
2013-04-24 13:55 ` Jason Cooper
2013-04-24 14:23 ` Andrew Lunn
2013-04-24 16:55 ` Kevin Hilman
2013-04-25 12:09 ` Linus Walleij
2013-04-25 18:27 ` Rafael J. Wysocki
2013-04-26 8:32 ` Linus Walleij
2013-04-26 10:53 ` Daniel Lezcano
2013-04-24 17:50 ` Rob Herring [this message]
2013-04-25 6:45 ` Daniel Lezcano
2013-04-25 6:49 ` Viresh Kumar
2013-04-25 7:06 ` Daniel Lezcano
2013-04-25 15:50 ` Rob Herring
2013-04-25 16:32 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51781B48.30208@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).