[PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation.

Arnd Bergmann
2015-10-08T15:11:32Z

On Thursday 08 October 2015 10:02:43 Bjorn Helgaas wrote:
> [+cc Arnd]
>
> And this one?

Not so good.

> > --- a/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.txt
> > @@ -34,7 +34,11 @@ Properties of the host controller node:
> > - #size-cells : Must be 2.
> >
> > - reg : The Configuration Space base address and size, as accessed
> > - from the parent bus.
> > + from the parent bus. The base address corresponds to
> > + bus zero, even though the "bus-range" property may specify
> > + a different starting bus number. The driver must only map
> > + or access the portion of the Configuration Space that
> > + corresponds to the "bus-range"

I thought we had reached an agreement that it is a bad idea to have a 'reg'
property that lists registers belonging to a different device.

Arnd