[PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation.

David Daney
2015-10-08T15:39:58Z

On 10/08/2015 08:18 AM, Arnd Bergmann wrote:
> On Thursday 08 October 2015 17:11:32 Arnd Bergmann wrote:
>>>> --- a/Documentation/devicetree/bindings/pci/host-generic-pci.txt
>>>> +++ b/Documentation/devicetree/bindings/pci/host-generic-pci.txt
>>>> @@ -34,7 +34,11 @@ Properties of the host controller node:
>>>> - #size-cells : Must be 2.
>>>>
>>>> - reg : The Configuration Space base address and size, as accessed
>>>> - from the parent bus.
>>>> + from the parent bus. The base address corresponds to
>>>> + bus zero, even though the "bus-range" property may specify
>>>> + a different starting bus number. The driver must only map
>>>> + or access the portion of the Configuration Space that
>>>> + corresponds to the "bus-range"
>>
>> I thought we had reached an agreement that it is a bad idea to have a 'reg'
>> property that lists registers belonging to a different device.
>>
>>
>
> To further clarify: the argument was to make it mirror what ACPI does for
> PCI. However, this is unlike what all other devices do with DT, where you
> have non-overlapping register ranges (start, length) for each device.
> ACPI as far as I understand it does not give a range for a PCIe host, but
> instead provides a way to get the start address of the ECAM register area
> for the domain that the host is part of, and that needs to be the same
> address for each host in the domain.
>

We are agreed that it is a bad thing to do. There is disagreement about
if we should do it.

I think there are two schools of thought (I will attribute them to their
proponents and my apologies if I misrepresent someone's stance):

1) (Arnd) Don't make the the "reg" ranges overlap because it is ugly,
dangerous and arguably incorrect in general.

2) (Me, Will Deacon, Lorenzo Pieralisi) Overlapping "reg" properties
should be maintained, as that is the current behavior and seems to agree
with legacy OF device-tree specifications (although there is some debate
about this).

Because the driver is broken in this area (thus the patch), it indicates
that there are probably no users with non-zero starting bus numbers.
So, we may have some latitude to change it.

I will generate another patch that does it Arnd's way, and if Will is OK
with it, we might be able to do that instead. One thing is certain:
The driver is currently broken for non-zero starting bus numbers.

David Daney