linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: srivatsa.bhat@linux.vnet.ibm.com (Srivatsa S. Bhat)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle
Date: Thu, 25 Apr 2013 12:12:17 +0530	[thread overview]
Message-ID: <5178D049.9090303@linux.vnet.ibm.com> (raw)
In-Reply-To: <1366849153-25564-1-git-send-email-khilman@linaro.org>

On 04/25/2013 05:49 AM, Kevin Hilman wrote:
> commit d1669912 (idle: Implement generic idle function) added a new
> generic idle along with support for hlt/nohlt command line options to
> override default idle loop behavior.  However, the command-line
> processing is never compiled.
> 
> The command-line handling is wrapped by CONFIG_GENERIC_IDLE_POLL_SETUP
> and arches that use this feature select it in their Kconfigs.
> However, no Kconfig definition was created for this option, so it is
> never enabled, and therefore command-line override of the idle-loop
> behavior is broken after migrating to the generic idle loop.
> 
> To fix, add a Kconfig definition for GENERIC_IDLE_POLL_SETUP.
> 
> Tested on ARM (OMAP4/Panda) which enables the command-line overrides
> by default.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Paul McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Signed-off-by: Kevin Hilman <khilman@linaro.org>
> ---

Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>

Regards,
Srivatsa S. Bhat

> Applies on tip/smp/hotplug where generic idle feature is added
>
>  arch/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/Kconfig b/arch/Kconfig
> index 1455579..e0ef57b 100644
> --- a/arch/Kconfig
> +++ b/arch/Kconfig
> @@ -216,6 +216,9 @@ config USE_GENERIC_SMP_HELPERS
>  config GENERIC_SMP_IDLE_THREAD
>         bool
> 
> +config GENERIC_IDLE_POLL_SETUP
> +       bool
> +
>  # Select if arch init_task initializer is different to init/init_task.c
>  config ARCH_INIT_TASK
>         bool
> 

  reply	other threads:[~2013-04-25  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25  0:19 [PATCH] idle: fix hlt/nohlt command-line handling in new generic idle Kevin Hilman
2013-04-25  6:42 ` Srivatsa S. Bhat [this message]
2013-04-29 23:43   ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5178D049.9090303@linux.vnet.ibm.com \
    --to=srivatsa.bhat@linux.vnet.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).