From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22770C433B4 for ; Thu, 15 Apr 2021 21:14:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 824876113D for ; Thu, 15 Apr 2021 21:14:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 824876113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FZUuyBUiy6MuvgYw1WFK8H7dfgFget5esEe4J+AvWBY=; b=L7Gts0sVbepi7MeN3RRjTx6Xt fgXKzc5TozycZBIDiN1WDEqAwPidWPwc5eFmAZE1fIZf6UCQF5kUg8F5reMqvf1FEsIHH9x5YJDEY 8l749XNQ2A2MAUVIG3Jmdk0O48Kyn8/AszgKHMUDef8riIvR9nSP2DAlZctA91vD6rJ4cOjI3O+0U 3f2qUxijqxtaCznjAWH391K70T63ay9dvraAtcHOrr4rQlVymfnVrLvvPAt7stIVN2DULLnWPHm3v XY/Wp8EnrZTQJ8pb4K4E4AGesuw83raN2MWp1SVPL1Hwp69LTxuU7cqbxw9UU2AHwm2iCrXogwUYL TqHDjbTOQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX9HY-00HM8P-Cu; Thu, 15 Apr 2021 21:12:12 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX9HU-00HM7g-GA for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 21:12:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:In-Reply-To:References:Message-ID:Date:Subject:CC: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=kdByWjhRMMfsZDkDw1PdhuuqF3vWBz8CLQMSKVrYim8=; b=v1ot0nbvSbIyi7irzxPeMxjD5x J7zlr4F5Gn3wZi07UgEQCqSHAF5HudwwklKFeORAZg5JIaKJ65g0LliuOZh7PR7huP9CGCZEk4+Rp mGnkr8OFHttSyGfp8oVzNaQi4m39BnF4ChvOhxcGTQxqbyrpN4bhWLZ1natqOgBEt3+qg0cXZzJ0x 6kUjJNJWLmTrp5TsY8MDZRlDdf5FZqiEf8LHV5bbCPDUqfkAmc201lR/xiIyYZDkg8I47+pNigO4T AWTCULTaLto1ihr70zRhRgBq6ZUvqb5xoyGWmNKc9LzawmSeHYpWzL47VsheEybqwLL6VSPIw8OTh tiiUipWw==; Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX9HQ-008tVm-Py for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 21:12:06 +0000 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-157-edG-rOXuODirktZxzgM_1A-1; Thu, 15 Apr 2021 22:11:57 +0100 X-MC-Unique: edG-rOXuODirktZxzgM_1A-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 15 Apr 2021 22:11:56 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.012; Thu, 15 Apr 2021 22:11:56 +0100 From: David Laight To: 'Matthew Wilcox' , Jesper Dangaard Brouer CC: "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , Ilias Apalodimas , Matteo Croce , Grygorii Strashko , Arnd Bergmann , "Christoph Hellwig" Subject: RE: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems Thread-Topic: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems Thread-Index: AQHXMXYmwdfrgigLI0exh4xFUSZq9Kq0jZ3ggAFYFFmAAC15oA== Date: Thu, 15 Apr 2021 21:11:56 +0000 Message-ID: <5179a01a462f43d6951a65de2a299070@AcuMS.aculab.com> References: <20210410205246.507048-2-willy@infradead.org> <20210411114307.5087f958@carbon> <20210411103318.GC2531743@casper.infradead.org> <20210412011532.GG2531743@casper.infradead.org> <20210414101044.19da09df@carbon> <20210414115052.GS2531743@casper.infradead.org> <20210414211322.3799afd4@carbon> <20210414213556.GY2531743@casper.infradead.org> <20210415200832.32796445@carbon> <20210415182155.GD2531743@casper.infradead.org> In-Reply-To: <20210415182155.GD2531743@casper.infradead.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_141205_119601_B766886A X-CRM114-Status: GOOD ( 15.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Matthew Wilcox > Sent: 15 April 2021 19:22 > > On Thu, Apr 15, 2021 at 08:08:32PM +0200, Jesper Dangaard Brouer wrote: > > +static inline > > +dma_addr_t page_pool_dma_addr_read(dma_addr_t dma_addr) > > +{ > > + /* Workaround for storing 64-bit DMA-addr on 32-bit machines in struct > > + * page. The page->dma_addr share area with page->compound_head which > > + * use bit zero to mark compound pages. This is okay, as DMA-addr are > > + * aligned pointers which have bit zero cleared. > > + * > > + * In the 32-bit case, page->compound_head is 32-bit. Thus, when > > + * dma_addr_t is 64-bit it will be located in top 32-bit. Solve by > > + * swapping dma_addr 32-bit segments. > > + */ > > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT > > #if defined(CONFIG_ARCH_DMA_ADDR_T_64BIT) && defined(__BIG_ENDIAN) > otherwise you'll create the problem on ARM that you're avoiding on PPC ... > > I think you want to delete the word '_read' from this function name because > you're using it for both read and write. I think I'd use explicit dma_addr_hi and dma_addr_lo and separate read/write functions just to make absolutely sure nothing picks up the swapped value. Isn't it possible to move the field down one long? This might require an explicit zero - but this is not a common code path - the extra write will be noise. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel