From: csd@broadcom.com (Christian Daudt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: bcm: mark bcm_kona_smc_init as __init
Date: Fri, 26 Apr 2013 08:41:55 -0700 [thread overview]
Message-ID: <517AA043.30005@broadcom.com> (raw)
In-Reply-To: <201304231744.40614.arnd@arndb.de>
On 13-04-23 08:44 AM, Arnd Bergmann wrote:
> The bcm_kona_smc_init function references the bcm_kona_smc_ids variable
> that is marked __initconst, so the function itself has to be __init
> to avoid this build error:
>
> WARNING: arch/arm/mach-bcm/built-in.o(.text+0x12c): Section mismatch in reference from the function bcm_kona_smc_init() to the (unknown reference) .init.rodata:(unknown)
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Christian Daudt <csd@broadcom.com>
> ---
> I have applied this trivial fix to the next/firmware branch
>
> diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
> index 5f1d131..56d9d19 100644
> --- a/arch/arm/mach-bcm/bcm_kona_smc.c
> +++ b/arch/arm/mach-bcm/bcm_kona_smc.c
> @@ -41,7 +41,7 @@ static const struct of_device_id bcm_kona_smc_ids[] __initconst = {
> };
>
> /* Map in the bounce area */
> -void bcm_kona_smc_init(void)
> +void __init bcm_kona_smc_init(void)
> {
> struct device_node *node;
>
>
acked-by: Christian Daudt <csd@broadcom.com>
prev parent reply other threads:[~2013-04-26 15:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 15:44 [PATCH] ARM: bcm: mark bcm_kona_smc_init as __init Arnd Bergmann
2013-04-26 15:41 ` Christian Daudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517AA043.30005@broadcom.com \
--to=csd@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).