* [PATCH] ARM: bcm: mark bcm_kona_smc_init as __init
@ 2013-04-23 15:44 Arnd Bergmann
2013-04-26 15:41 ` Christian Daudt
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2013-04-23 15:44 UTC (permalink / raw)
To: linux-arm-kernel
The bcm_kona_smc_init function references the bcm_kona_smc_ids variable
that is marked __initconst, so the function itself has to be __init
to avoid this build error:
WARNING: arch/arm/mach-bcm/built-in.o(.text+0x12c): Section mismatch in reference from the function bcm_kona_smc_init() to the (unknown reference) .init.rodata:(unknown)
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Christian Daudt <csd@broadcom.com>
---
I have applied this trivial fix to the next/firmware branch
diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
index 5f1d131..56d9d19 100644
--- a/arch/arm/mach-bcm/bcm_kona_smc.c
+++ b/arch/arm/mach-bcm/bcm_kona_smc.c
@@ -41,7 +41,7 @@ static const struct of_device_id bcm_kona_smc_ids[] __initconst = {
};
/* Map in the bounce area */
-void bcm_kona_smc_init(void)
+void __init bcm_kona_smc_init(void)
{
struct device_node *node;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: bcm: mark bcm_kona_smc_init as __init
2013-04-23 15:44 [PATCH] ARM: bcm: mark bcm_kona_smc_init as __init Arnd Bergmann
@ 2013-04-26 15:41 ` Christian Daudt
0 siblings, 0 replies; 2+ messages in thread
From: Christian Daudt @ 2013-04-26 15:41 UTC (permalink / raw)
To: linux-arm-kernel
On 13-04-23 08:44 AM, Arnd Bergmann wrote:
> The bcm_kona_smc_init function references the bcm_kona_smc_ids variable
> that is marked __initconst, so the function itself has to be __init
> to avoid this build error:
>
> WARNING: arch/arm/mach-bcm/built-in.o(.text+0x12c): Section mismatch in reference from the function bcm_kona_smc_init() to the (unknown reference) .init.rodata:(unknown)
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Christian Daudt <csd@broadcom.com>
> ---
> I have applied this trivial fix to the next/firmware branch
>
> diff --git a/arch/arm/mach-bcm/bcm_kona_smc.c b/arch/arm/mach-bcm/bcm_kona_smc.c
> index 5f1d131..56d9d19 100644
> --- a/arch/arm/mach-bcm/bcm_kona_smc.c
> +++ b/arch/arm/mach-bcm/bcm_kona_smc.c
> @@ -41,7 +41,7 @@ static const struct of_device_id bcm_kona_smc_ids[] __initconst = {
> };
>
> /* Map in the bounce area */
> -void bcm_kona_smc_init(void)
> +void __init bcm_kona_smc_init(void)
> {
> struct device_node *node;
>
>
acked-by: Christian Daudt <csd@broadcom.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-26 15:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-23 15:44 [PATCH] ARM: bcm: mark bcm_kona_smc_init as __init Arnd Bergmann
2013-04-26 15:41 ` Christian Daudt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).