From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: Array subscript above array bounds warning
Date: Sun, 28 Apr 2013 11:29:26 +1200 [thread overview]
Message-ID: <517C5F56.7040106@prisktech.co.nz> (raw)
Could someone clarify for me what I am missing here?
in drivers/net/ethernet/via/velocity.h is the following definition:
struct mac_regs {
volatile u8 PAR[6]; /* 0x00 */
...
}
I am trying to add the following function but it keeps giving array
bounds warnings:
static void velocity_set_power_state(struct velocity_info *vptr, char state)
{
struct mac_regs __iomem *regs = vptr->mac_regs;
if (vptr->bustype == BUS_PCI) {
pci_set_power_state(vptr->pdev, state);
} else {
writeb(state, (®s->PAR[0]) + 0x154);
}
}
gives:
/home/sentient/linux-git/server/arch/arm/include/asm/io.h:83:2: warning:
array subscript is above array bounds [-Warray-bounds]
If I change the function to:
static void velocity_set_power_state(struct velocity_info *vptr, char state)
{
void __iomem *addr;
struct mac_regs __iomem *regs = vptr->mac_regs;
if (vptr->bustype == BUS_PCI)
pci_set_power_state(vptr->pdev, state);
else {
addr = ®s->PAR[0];
writeb(state, addr + 0x154);
}
}
I get the following warning:
drivers/net/ethernet/via/via-velocity.c:99:8: warning: assignment
discards ?volatile? qualifier from pointer target type [enabled by default]
What is the correct way to go about this?
Regards
Tony Prisk
next reply other threads:[~2013-04-27 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 23:29 Tony Prisk [this message]
2013-04-27 23:54 ` Array subscript above array bounds warning Emilio López
2013-04-28 1:37 ` Tony Prisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517C5F56.7040106@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).