From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: linux-next build error (at91) - use of bool in mach/arch.h
Date: Tue, 30 Apr 2013 14:40:27 +0200 [thread overview]
Message-ID: <517FBBBB.6060003@atmel.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1304301257200.5398@kaball.uk.xensource.com>
On 04/30/2013 01:58 PM, Stefano Stabellini :
> On Tue, 30 Apr 2013, Geert Uytterhoeven wrote:
>> On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>>> So, I am wondering if the best correction is to add the types.h header file
>>> in the asm/mach/arch.h file, like this:
>>>
>>> --- a/arch/arm/include/asm/mach/arch.h
>>> +++ b/arch/arm/include/asm/mach/arch.h
>>> @@ -8,6 +8,8 @@
>>> * published by the Free Software Foundation.
>>> */
>>>
>>> +#include <linux/types.h>
>>> +
>>> #ifndef __ASSEMBLY__
>>>
>>> struct tag;
>>>
>>> or if a better option would be to re-arrange the include directives in
>>> various at91xxx_devices.c files?
>>
>> Include files should be self-contained, so asm/mach/arch.h is the right place.
>
> Nicolas,
> are you happy to come up with a proper patch to fix the issue?
Yep, sent now.
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2013-04-30 12:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 9:33 linux-next build error (at91) - use of bool in mach/arch.h Nicolas Ferre
2013-04-30 9:39 ` Geert Uytterhoeven
2013-04-30 11:58 ` Stefano Stabellini
2013-04-30 12:40 ` Nicolas Ferre [this message]
2013-04-30 15:15 ` Nicolas Pitre
2013-04-30 15:59 ` Stefano Stabellini
2013-04-30 12:38 ` [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h Nicolas Ferre
2013-04-30 14:05 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FBBBB.6060003@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).