From: cov@codeaurora.org (Christopher Covington)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] arm: Move the set_handle_irq and handle_arch_irq declarations to asm/irq.h
Date: Tue, 30 Apr 2013 13:22:11 -0400 [thread overview]
Message-ID: <517FFDC3.5030803@codeaurora.org> (raw)
In-Reply-To: <1363714703-9629-2-git-send-email-catalin.marinas@arm.com>
Hi Catalin,
On 03/19/2013 01:38 PM, Catalin Marinas wrote:
> This patch prepares the removal of <asm/mach/irq.h> include in the
> GIC and VIC irqchip drivers.
[...]
> diff --git a/drivers/irqchip/irq-vic.c b/drivers/irqchip/irq-vic.c
> index 3cf97aa..e38cb00 100644
> --- a/drivers/irqchip/irq-vic.c
> +++ b/drivers/irqchip/irq-vic.c
> @@ -33,7 +33,7 @@
> #include <linux/irqchip/arm-vic.h>
>
> #include <asm/exception.h>
> -#include <asm/mach/irq.h>
> +#include <asm/irq.h>
>
> #include "irqchip.h"
I'm seeing implicit declaration of function issues using your soc-armv8-model
branch that seem to be caused by this change.
drivers/irqchip/irq-vic.c: In function ?vic_irqdomain_map?:
drivers/irqchip/irq-vic.c:200:2: error: implicit declaration of function
?irq_set_chip_and_handler? [-Werror=implicit-function-declaration]
drivers/irqchip/irq-vic.c:200:43: error: ?handle_level_irq? undeclared (first
use in this function)
etc.
Explicitly including linux/irq.h fixed the issue for me.
Regards,
Christopher
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.
next prev parent reply other threads:[~2013-04-30 17:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 17:38 [PATCH v3 0/4] Preparatory GIC patches for arm64 support Catalin Marinas
2013-03-19 17:38 ` [PATCH v3 1/4] arm: Move the set_handle_irq and handle_arch_irq declarations to asm/irq.h Catalin Marinas
2013-04-30 17:22 ` Christopher Covington [this message]
2013-03-19 17:38 ` [PATCH v3 2/4] arm: Move chained_irq_(enter|exit) to a generic file Catalin Marinas
2013-03-19 17:38 ` [PATCH v3 3/4] irqchip: gic: Call handle_bad_irq() directly Catalin Marinas
2013-03-19 17:38 ` [PATCH v3 4/4] irqchip: gic: Perform the gic_secondary_init() call via CPU notifier Catalin Marinas
2013-03-26 22:29 ` [PATCH v3 0/4] Preparatory GIC patches for arm64 support Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FFDC3.5030803@codeaurora.org \
--to=cov@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).