* [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
@ 2025-02-28 16:31 Yao Zi
2025-02-28 16:55 ` Diederik de Haas
2025-02-28 22:01 ` Heiko Stuebner
0 siblings, 2 replies; 5+ messages in thread
From: Yao Zi @ 2025-02-28 16:31 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Dragan Simic, Johan Jonker, Diederik de Haas, Wenhao Cui,
Yuteng Zhong
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Yao Zi
Property "supports-cd" isn't documented anywhere and is unnecessary for
mainline driver to function. It seems a property used by downstream
kernel was brought into mainline.
This should be reported by dtbs_check, but mmc-controller-common.yaml
defaults additionalProperties to true thus allows it. Remove the
property to clean the devicetree up and avoid possible confusion.
Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
Signed-off-by: Yao Zi <ziyao@disroot.org>
---
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
index 61dd71c259aa..ddf84c2a19cf 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
@@ -512,7 +512,6 @@ &sdhci {
&sdmmc0 {
max-frequency = <150000000>;
- supports-sd;
bus-width = <4>;
cap-mmc-highspeed;
cap-sd-highspeed;
--
2.48.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
2025-02-28 16:31 [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 Yao Zi
@ 2025-02-28 16:55 ` Diederik de Haas
2025-02-28 17:59 ` Yao Zi
2025-02-28 22:01 ` Heiko Stuebner
1 sibling, 1 reply; 5+ messages in thread
From: Diederik de Haas @ 2025-02-28 16:55 UTC (permalink / raw)
To: Yao Zi, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, Dragan Simic, Johan Jonker, Wenhao Cui,
Yuteng Zhong
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]
On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote:
> Property "supports-cd" isn't documented anywhere and is unnecessary for
s/supports-cd/supports-sd/ ?
Cheers,
Diederik
> mainline driver to function. It seems a property used by downstream
> kernel was brought into mainline.
>
> This should be reported by dtbs_check, but mmc-controller-common.yaml
> defaults additionalProperties to true thus allows it. Remove the
> property to clean the devicetree up and avoid possible confusion.
>
> Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> index 61dd71c259aa..ddf84c2a19cf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> @@ -512,7 +512,6 @@ &sdhci {
>
> &sdmmc0 {
> max-frequency = <150000000>;
> - supports-sd;
> bus-width = <4>;
> cap-mmc-highspeed;
> cap-sd-highspeed;
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
2025-02-28 16:55 ` Diederik de Haas
@ 2025-02-28 17:59 ` Yao Zi
2025-02-28 18:05 ` Heiko Stübner
0 siblings, 1 reply; 5+ messages in thread
From: Yao Zi @ 2025-02-28 17:59 UTC (permalink / raw)
To: Diederik de Haas, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, Dragan Simic, Johan Jonker, Wenhao Cui,
Yuteng Zhong
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On Fri, Feb 28, 2025 at 05:55:47PM +0100, Diederik de Haas wrote:
> On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote:
> > Property "supports-cd" isn't documented anywhere and is unnecessary for
>
> s/supports-cd/supports-sd/ ?
Oops, yes, it's a typo.
As it's a trival patch, could it be fixed on merging? Or should I send
another version?
> Cheers,
> Diederik
Thanks,
Yao Zi
> > mainline driver to function. It seems a property used by downstream
> > kernel was brought into mainline.
> >
> > This should be reported by dtbs_check, but mmc-controller-common.yaml
> > defaults additionalProperties to true thus allows it. Remove the
> > property to clean the devicetree up and avoid possible confusion.
> >
> > Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
> > Signed-off-by: Yao Zi <ziyao@disroot.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
2025-02-28 17:59 ` Yao Zi
@ 2025-02-28 18:05 ` Heiko Stübner
0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2025-02-28 18:05 UTC (permalink / raw)
To: Diederik de Haas, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Dragan Simic, Johan Jonker, Wenhao Cui, Yuteng Zhong, Yao Zi
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Hi,
Am Freitag, 28. Februar 2025, 18:59:42 MEZ schrieb Yao Zi:
> On Fri, Feb 28, 2025 at 05:55:47PM +0100, Diederik de Haas wrote:
> > On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote:
> > > Property "supports-cd" isn't documented anywhere and is unnecessary for
> >
> > s/supports-cd/supports-sd/ ?
>
> Oops, yes, it's a typo.
>
> As it's a trival patch, could it be fixed on merging? Or should I send
> another version?
I can change that when applying.
Heiko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
2025-02-28 16:31 [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 Yao Zi
2025-02-28 16:55 ` Diederik de Haas
@ 2025-02-28 22:01 ` Heiko Stuebner
1 sibling, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2025-02-28 22:01 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Dragan Simic,
Johan Jonker, Diederik de Haas, Wenhao Cui, Yuteng Zhong, Yao Zi
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On Fri, 28 Feb 2025 16:31:18 +0000, Yao Zi wrote:
> Property "supports-cd" isn't documented anywhere and is unnecessary for
> mainline driver to function. It seems a property used by downstream
> kernel was brought into mainline.
>
> This should be reported by dtbs_check, but mmc-controller-common.yaml
> defaults additionalProperties to true thus allows it. Remove the
> property to clean the devicetree up and avoid possible confusion.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
commit: 43c854c65e47d2f3763345683b06257b4d12e4e3
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-28 22:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-28 16:31 [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 Yao Zi
2025-02-28 16:55 ` Diederik de Haas
2025-02-28 17:59 ` Yao Zi
2025-02-28 18:05 ` Heiko Stübner
2025-02-28 22:01 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).