From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152BDC31E4C for ; Fri, 14 Jun 2019 09:37:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9DE42082C for ; Fri, 14 Jun 2019 09:37:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WKaB47L7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9DE42082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NuQ5Kx/TAivARILc/BRqIaBiFtSTA33hPIQkr+2m5ZY=; b=WKaB47L7k7s0Ru AJNYuw6ZRVXgVamDhs2hPIuiWXBzUVcRdhJ7ChiuNTdB5UcSuPOCEW8UQtG7/Sz+GMu+cw7TdC+6W MSRwQksxZ1Ox4WU32kr40yLBvcXXQntGVgMoV/nl8YVCHQGTJDvoZ7T/JLsG4/iFQHSB6SuZtOCSG rMYBXLlGSsWhIfdmxZ/ZIao7W+f0BIG42HEzYesq8H5waufAQ3M4kVrGlvVio2zcdE4fc7kDoGjSd OFtA1lPPAeYokjJPB3bsbBjBtOs0iq7uzFQspREExzcaSbypn/NnoCFVvTF0p1maVIXgbf1/e/Sei lseXu6nWXgcwoA97OV9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbieE-0000dy-KP; Fri, 14 Jun 2019 09:37:26 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbicW-0007mP-0E; Fri, 14 Jun 2019 09:35:44 +0000 Received: from we0305.dip.tu-dresden.de ([141.76.177.49] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hbicI-00048J-FR; Fri, 14 Jun 2019 11:35:26 +0200 From: Heiko Stuebner To: Daniel Lezcano Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi Date: Fri, 14 Jun 2019 11:35:25 +0200 Message-ID: <5188064.YWmxIpmbGp@phil> In-Reply-To: <20190604165802.7338-1-daniel.lezcano@linaro.org> References: <20190604165802.7338-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190614_023540_315901_0D8CB988 X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Emil Renner Berthing , "open list:ARM/Rockchip SoC support" , Tony Xie , Viresh Kumar , Randy Li , linux-kernel@vger.kernel.org, Vicente Bergas , dianders@chromium.org, edubezval@gmail.com, Enric Balletbo i Serra , Rob Herring , Klaus Goger , manivannan.sadhasivam@linaro.org, Matthias Brugger , Philipp Tomsich , robin.murphy@arm.com, "moderated list:ARM/Rockchip SoC support" , Christoph Muellner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, Am Dienstag, 4. Juni 2019, 18:57:57 CEST schrieb Daniel Lezcano: > Currently the common thermal zones definitions for the rk3399 assumes > multiple thermal zones are supported by the governors. This is not the > case and each thermal zone has its own governor instance acting > individually without collaboration with other governors. > > As the cooling device for the CPU and the GPU thermal zones is the > same, each governors take different decisions for the same cooling > device leading to conflicting instructions and an erratic behavior. > > As the cooling-maps is about to become an optional property, let's > remove the cpu cooling device map from the GPU thermal zone. > > Signed-off-by: Daniel Lezcano > --- > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index 196ac9b78076..e1357e0f60f7 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -821,15 +821,6 @@ > type = "critical"; > }; > }; > - > - cooling-maps { > - map0 { > - trip = <&gpu_alert0>; > - cooling-device = > - <&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, > - <&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > - }; > - }; > }; > }; my knowledge of the thermal framework is not that big, but what about the rk3399-devices which further detail the cooling-maps like rk3399-gru-kevin and the rk3399-nanopc-t4 with its fan-handling in the cooling-maps? Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel