From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] irqchip: Add irqchip_init dummy function
Date: Wed, 08 May 2013 22:51:38 +0400 [thread overview]
Message-ID: <518A9EBA.6070609@cogentembedded.com> (raw)
In-Reply-To: <201305081833.03716.arnd@arndb.de>
Hello.
On 05/08/2013 08:33 PM, Arnd Bergmann wrote:
>
>>> --- a/include/linux/irqchip.h
>>> +++ b/include/linux/irqchip.h
>>> @@ -11,6 +11,10 @@
>>> #ifndef _LINUX_IRQCHIP_H
>>> #define _LINUX_IRQCHIP_H
>>>
>>> +#ifdef CONFIG_IRQCHIP
>>> void irqchip_init(void);
>>> +#else
>>> +void irqchip_init(void) {};
>> Semicolon not needed here.
>>
>>> +#endif
> More importantly, the function should be marked as "static inline", otherwise
> you get a link error if this header is included in more than one place.
Right, I should have noticed that too. :-)
> Arnd
WBR, Sergei
next prev parent reply other threads:[~2013-05-08 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:20 [PATCH] irqchip: Add irqchip_init dummy function Bastian Hecht
2013-05-08 15:15 ` Sergei Shtylyov
2013-05-08 16:33 ` Arnd Bergmann
2013-05-08 18:51 ` Sergei Shtylyov [this message]
2013-05-09 3:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A9EBA.6070609@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).