From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: tegra20: convert device tree files to use CLK defines
Date: Mon, 13 May 2013 10:54:36 -0600 [thread overview]
Message-ID: <51911ACC.5010507@wwwdotorg.org> (raw)
In-Reply-To: <1368443225-16978-3-git-send-email-hdoyu@nvidia.com>
On 05/13/2013 05:07 AM, Hiroshi Doyu wrote:
> Replace magic number in tegra_car:
>
> - clocks = <&tegra_car 28>;
> + clocks = <&tegra_car CLK_HOST1X>;
Patches 2, 4, 6 look basically fine. I'd also like slightly more
explanation in the commit description here. How about:
=====
Use the Tegra20 CAR binding header (tegra20-car.h) to replace magic
numbers in the device tree. For example,
- clocks = <&tegra_car 28>;
+ clocks = <&tegra_car CLK_HOST1X>;
=====
> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
> #include <dt-bindings/gpio/tegra-gpio.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/clk/tegra20-car.h>
Can we keep the include files sorted?
One dependency issue with patches 2: There is a series of USB patches
(which Venu posted in the last couple of days) that fix the USB binding
to be complete. These will change the set of clocks referenced by the
EHCI and USB PHY nodes. I would like Venu's patches to be applied first,
since those DT changes will need to be merged into the USB tree so that
the USB tree can apply the subsequent driver changes. Can you hold off
on reposting your series until after I've applied Venu's changes, and
rebase this series on top of them? Hopefully it shouldn't take too long
to get Venu's series applied. Thanks.
next prev parent reply other threads:[~2013-05-13 16:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 11:06 [PATCH 0/6] CLK: tegra: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-13 11:07 ` [PATCH 1/6] ARM: tegra20: create a DT header defining CLK IDs Hiroshi Doyu
2013-05-13 16:46 ` Stephen Warren
2013-05-14 5:59 ` Hiroshi Doyu
2013-05-13 16:47 ` Stephen Warren
2013-05-13 11:07 ` [PATCH 2/6] ARM: tegra20: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-13 16:54 ` Stephen Warren [this message]
2013-05-13 11:07 ` [PATCH 3/6] ARM: tegra30: create a DT header defining CLK IDs Hiroshi Doyu
2013-05-13 11:07 ` [PATCH 4/6] ARM: tegra30: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-13 11:07 ` [PATCH 5/6] ARM: tegra114: create a DT header defining CLK IDs Hiroshi Doyu
2013-05-13 11:07 ` [PATCH 6/6] ARM: tegra114: convert device tree files to use CLK defines Hiroshi Doyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51911ACC.5010507@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).