linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dinh.linux@gmail.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA
Date: Wed, 15 May 2013 11:44:08 -0500	[thread overview]
Message-ID: <5193BB58.2040109@gmail.com> (raw)
In-Reply-To: <20130515124302.GB9066@amd.pavel.ucw.cz>

Hi Pavel,

Thanks for the review...

On 05/15/2013 07:43 AM, Pavel Machek wrote:
> On Tue 2013-05-14 17:52:31, dinguyen at altera.com wrote:
>> From: Dinh Nguyen <dinguyen@altera.com>
>>
>> Add entry for 2nd GMAC controller. Add the correct clocks for the GMAC.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen@altera.com>
>> CC: Arnd Bergmann <arnd@arndb.de>
>> CC: Olof Johansson <olof@lixom.net>
>> CC: Pavel Machek <pavel@denx.de>
>> CC: <linux@arm.linux.org.uk>
> 
> Looks good.
> 
> Reviewed-by: Pavel Machek <pavel@denx.de>
> 
> ...but, this patch is not enough to get ethernet to work with
> 3.10-rc1, right? I hoped that applying 1-3 of the series would get me
> ethernet, but no :-(.

Yes, this fixes a build error for socfpga_defconfig in 3.10-rc1. I'll
send a patch to enable ethernet after these patches are accepted.

Dinh


> 
> Thanks,
> 									Pavel
> 

  reply	other threads:[~2013-05-15 16:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 22:52 [PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA dinguyen at altera.com
2013-05-14 22:52 ` [PATCH 2/5] ARM: socfpga: dts: Add gate-clock bindings dinguyen at altera.com
2013-05-15 13:06   ` Pavel Machek
2013-05-14 22:52 ` [PATCH 3/5] ARM: socfpga: Add support to gate peripheral clocks dinguyen at altera.com
2013-05-15 13:58   ` Pavel Machek
2013-05-14 22:52 ` [PATCH 4/5] ARM: socfpga: dts: Add support for SD/MMC dinguyen at altera.com
2013-05-15 13:05   ` Pavel Machek
2013-05-14 22:52 ` [PATCH 5/5] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA dinguyen at altera.com
2013-05-15  4:28   ` Jaehoon Chung
2013-05-15 16:27     ` Dinh Nguyen
2013-05-15 13:25   ` Arnd Bergmann
2013-05-15 16:40     ` Dinh Nguyen
2013-05-15 17:11       ` Arnd Bergmann
2013-05-15 19:18         ` Dinh Nguyen
2013-05-15 12:43 ` [PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA Pavel Machek
2013-05-15 16:44   ` Dinh Nguyen [this message]
2013-05-15 13:19 ` Arnd Bergmann
2013-05-15 16:44   ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5193BB58.2040109@gmail.com \
    --to=dinh.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).