From: dinh.linux@gmail.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA
Date: Wed, 15 May 2013 11:44:47 -0500 [thread overview]
Message-ID: <5193BB7F.8030404@gmail.com> (raw)
In-Reply-To: <201305151519.08598.arnd@arndb.de>
Hi Arnd,
On 05/15/2013 08:19 AM, Arnd Bergmann wrote:
> On Wednesday 15 May 2013, dinguyen at altera.com wrote:
>> };
>>
>> + ethernet at ff700000 {
>> + phy-mode = "gmii";
>> + };
>> +
>> + ethernet at ff702000 {
>> + status = "disabled";
>> + };
>
> By convention, please mark the controllers as "disabled" in the main .dtsi file
> and only enable them in the board specific files when used, rather than the
> other way round.
Thanks for the review. Will fix.
Dinh
>
> Arnd
>
prev parent reply other threads:[~2013-05-15 16:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 22:52 [PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA dinguyen at altera.com
2013-05-14 22:52 ` [PATCH 2/5] ARM: socfpga: dts: Add gate-clock bindings dinguyen at altera.com
2013-05-15 13:06 ` Pavel Machek
2013-05-14 22:52 ` [PATCH 3/5] ARM: socfpga: Add support to gate peripheral clocks dinguyen at altera.com
2013-05-15 13:58 ` Pavel Machek
2013-05-14 22:52 ` [PATCH 4/5] ARM: socfpga: dts: Add support for SD/MMC dinguyen at altera.com
2013-05-15 13:05 ` Pavel Machek
2013-05-14 22:52 ` [PATCH 5/5] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA dinguyen at altera.com
2013-05-15 4:28 ` Jaehoon Chung
2013-05-15 16:27 ` Dinh Nguyen
2013-05-15 13:25 ` Arnd Bergmann
2013-05-15 16:40 ` Dinh Nguyen
2013-05-15 17:11 ` Arnd Bergmann
2013-05-15 19:18 ` Dinh Nguyen
2013-05-15 12:43 ` [PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA Pavel Machek
2013-05-15 16:44 ` Dinh Nguyen
2013-05-15 13:19 ` Arnd Bergmann
2013-05-15 16:44 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5193BB7F.8030404@gmail.com \
--to=dinh.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).