linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] tty: xuartps: Remove suspend/resume functions
Date: Fri, 17 May 2013 14:09:38 +0200	[thread overview]
Message-ID: <51961E02.9020501@monstr.eu> (raw)
In-Reply-To: <1368467199-8702-2-git-send-email-soren.brinkmann@xilinx.com>

Hi Greg,

can you please add this patch to your tree?
It is unrelated to clk changes which Soren sent.

Thanks,
Michal

On 05/13/2013 07:46 PM, Soren Brinkmann wrote:
> Currently Zynq does not support suspend/resume.
> The driver callbacks are never used or tested, broken and using the old
> PM interface.
> 
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Cc: linux-serial at vger.kernel.org
> ---
>  drivers/tty/serial/xilinx_uartps.c | 30 ------------------------------
>  1 file changed, 30 deletions(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 4e5c778..b5f655d 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -1006,34 +1006,6 @@ static int xuartps_remove(struct platform_device *pdev)
>  	return rc;
>  }
>  
> -/**
> - * xuartps_suspend - suspend event
> - * @pdev: Pointer to the platform device structure
> - * @state: State of the device
> - *
> - * Returns 0
> - **/
> -static int xuartps_suspend(struct platform_device *pdev, pm_message_t state)
> -{
> -	/* Call the API provided in serial_core.c file which handles
> -	 * the suspend.
> -	 */
> -	uart_suspend_port(&xuartps_uart_driver, &xuartps_port[pdev->id]);
> -	return 0;
> -}
> -
> -/**
> - * xuartps_resume - Resume after a previous suspend
> - * @pdev: Pointer to the platform device structure
> - *
> - * Returns 0
> - **/
> -static int xuartps_resume(struct platform_device *pdev)
> -{
> -	uart_resume_port(&xuartps_uart_driver, &xuartps_port[pdev->id]);
> -	return 0;
> -}
> -
>  /* Match table for of_platform binding */
>  static struct of_device_id xuartps_of_match[] = {
>  	{ .compatible = "xlnx,xuartps", },
> @@ -1044,8 +1016,6 @@ MODULE_DEVICE_TABLE(of, xuartps_of_match);
>  static struct platform_driver xuartps_platform_driver = {
>  	.probe   = xuartps_probe,		/* Probe method */
>  	.remove  = xuartps_remove,		/* Detach method */
> -	.suspend = xuartps_suspend,		/* Suspend */
> -	.resume  = xuartps_resume,		/* Resume after a suspend */
>  	.driver  = {
>  		.owner = THIS_MODULE,
>  		.name = XUARTPS_NAME,		/* Driver name */
> 


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130517/0fdc1a86/attachment.sig>

  reply	other threads:[~2013-05-17 12:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-13 17:46 [PATCH v2 0/5] Zynq: revised CCF code Soren Brinkmann
2013-05-13 17:46 ` [PATCH v2 1/5] tty: xuartps: Remove suspend/resume functions Soren Brinkmann
2013-05-17 12:09   ` Michal Simek [this message]
2013-05-20 18:57     ` Greg Kroah-Hartman
2013-05-13 17:46 ` [PATCH v2 2/5] clk: zynq: Factor out PLL driver Soren Brinkmann
2013-05-13 17:46 ` [PATCH v2 3/5] clk: zynq: Add clock controller driver Soren Brinkmann
2013-05-13 17:46 ` [PATCH v2 4/5] arm: zynq: Migrate platform to clock controller Soren Brinkmann
2013-05-13 17:46 ` [PATCH v2 5/5] clk: zynq: Remove deprecated clock code Soren Brinkmann
2013-05-17 12:14 ` [PATCH v2 0/5] Zynq: revised CCF code Michal Simek
2013-05-30 18:44   ` Mike Turquette
2013-05-31  5:17     ` Michal Simek
2013-05-31  6:32       ` Mike Turquette
2013-05-31  7:03         ` Michal Simek
2013-05-21 14:34 ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51961E02.9020501@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).