From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2 2/6] ARM: tegra20: convert device tree files to use CLK defines
Date: Tue, 21 May 2013 10:13:31 -0600 [thread overview]
Message-ID: <519B9D2B.5010101@wwwdotorg.org> (raw)
In-Reply-To: <1369127450-15203-3-git-send-email-hdoyu@nvidia.com>
On 05/21/2013 03:10 AM, Hiroshi Doyu wrote:
> Use the Tegra20 CAR binding header (tegra20-car.h) to replace magic
> numbers in the device tree. For example,
>
> - clocks = <&tegra_car 28>;
> + clocks = <&tegra_car CLK_HOST1X>;
> diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
> - clocks = <&tegra_car 112>, <&tegra_car 113>, <&tegra_car 94>;
> + clocks = <&tegra_car TEGRA20_CLK_PLL_A>, <&tegra_car TEGRA20_CLK_PLL_A_OUT0>, <&tegra_car TEGRA20_CLK_CDEV1>;
That's well over 80 columns. Can you wrap it and make sure there aren't
any other instances of this? I guess checkpatch doesn't actually impose
this rule on *.dts files, since it didn't complain about this.
prev parent reply other threads:[~2013-05-21 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 9:10 [v2 0/6] CLK: tegra: convert device tree files to use CLK defines Hiroshi Doyu
2013-05-21 16:05 ` Stephen Warren
2013-05-22 6:12 ` Hiroshi Doyu
2013-05-22 10:07 ` Hiroshi Doyu
2013-05-22 15:20 ` Stephen Warren
2013-05-22 15:19 ` Stephen Warren
[not found] ` <1369127450-15203-3-git-send-email-hdoyu@nvidia.com>
2013-05-21 16:13 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519B9D2B.5010101@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).