From mboxrd@z Thu Jan 1 00:00:00 1970 From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth) Date: Wed, 22 May 2013 11:43:15 +0200 Subject: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes In-Reply-To: <20130521174849.GL26249@lunn.ch> References: <1367854420-8006-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369154510-4927-7-git-send-email-sebastian.hesselbarth@gmail.com> <20130521174849.GL26249@lunn.ch> Message-ID: <519C9333.20609@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 05/21/2013 07:48 PM, Andrew Lunn wrote: > On Tue, May 21, 2013 at 06:41:44PM +0200, Sebastian Hesselbarth wrote: >> This patch adds orion-eth and mvmdio device tree nodes for DT enabled >> Dove boards. As there is only one ethernet controller on Dove, a default >> phy node is also added with a note to set its reg property on a per-board >> basis. >> >> Signed-off-by: Sebastian Hesselbarth >> --- ... >> + ethernet-port at 0 { >> + device_type = "network"; >> + compatible = "marvell,orion-eth-port"; >> + reg =<0>; >> + interrupts =<29>; >> + /* overwrite MAC address in bootloader */ >> + local-mac-address = [00 00 00 00 00 00]; > > Hi Sebastian > > Its probably a good idea to set the local administration bit in this > MAC address. i.e. first byte is 02. Andrew, we just need an invalid address here to trigger the default behavior of the driver and load the MAC address from its register. As PPC binding documentation also has all zero, I just took it. Sebastian