From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor
Date: Thu, 23 May 2013 10:54:26 -0700 [thread overview]
Message-ID: <519E57D2.3050000@codeaurora.org> (raw)
In-Reply-To: <5193E424.9090605@codeaurora.org>
On 05/15/13 12:38, Stephen Boyd wrote:
> On 05/08/13 14:47, Stephen Boyd wrote:
>> From: Brian Swetland <swetland@google.com>
>>
>> Currently v7 CPUs with an MIDR that has no bits set in the range
>> [16:12] will be detected as old ARM CPUs with no caches and so
>> the cache will never be turned on during decompression. ARM's
>> Cortex chips have an 0xC in the range [16:12] so they never match
>> this entry, but Qualcomm's Scorpion and Krait processors never
>> set these bits to anything besides 0 so they always match.
>>
>> Skip this entry if we've compiled in support for v7 CPUs. This
>> allows kernel decompression to happen nearly instantly instead of
>> taking over 20 seconds.
>>
>> Signed-off-by: Brian Swetland <swetland@google.com>
>> [sboyd: Clarified and extended commit text]
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>> ---
> Ping?
Russell, shall I add this to the patch tracker?
>
>> arch/arm/boot/compressed/head.S | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/compressed/head.S b/arch/arm/boot/compressed/head.S
>> index fe4d9c3..a236190 100644
>> --- a/arch/arm/boot/compressed/head.S
>> +++ b/arch/arm/boot/compressed/head.S
>> @@ -805,6 +805,8 @@ call_cache_fn: adr r12, proc_types
>> .align 2
>> .type proc_types,#object
>> proc_types:
>> +#if !defined(CONFIG_CPU_V7)
>> + /* This collides with some V7 IDs, preventing correct detection */
>> .word 0x00000000 @ old ARM ID
>> .word 0x0000f000
>> mov pc, lr
>> @@ -813,6 +815,7 @@ proc_types:
>> THUMB( nop )
>> mov pc, lr
>> THUMB( nop )
>> +#endif
>>
>> .word 0x41007000 @ ARM7/710
>> .word 0xfff8fe00
>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-05-23 17:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 21:47 [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor Stephen Boyd
2013-05-08 21:50 ` Stephen Boyd
2013-05-15 19:38 ` Stephen Boyd
2013-05-23 17:54 ` Stephen Boyd [this message]
2013-05-23 23:15 ` Russell King - ARM Linux
2013-05-24 22:05 ` Stephen Boyd
2013-06-03 21:13 ` Stephen Boyd
2013-06-03 21:33 ` Nicolas Pitre
2013-06-03 22:38 ` Russell King - ARM Linux
2013-06-03 22:23 ` Russell King - ARM Linux
2013-06-03 22:37 ` Stephen Boyd
2013-06-03 22:45 ` Russell King - ARM Linux
2013-06-03 22:59 ` Stephen Boyd
2013-06-04 5:27 ` Nicolas Pitre
2013-06-04 19:47 ` Stephen Boyd
2013-06-04 21:13 ` Nicolas Pitre
2013-06-04 21:45 ` Stephen Boyd
2013-06-05 2:23 ` Nicolas Pitre
2013-06-06 1:29 ` Stephen Boyd
2013-06-06 4:21 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519E57D2.3050000@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).