From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/6] drivers: bus: add a new driver for WEIM
Date: Fri, 24 May 2013 10:42:53 +0800 [thread overview]
Message-ID: <519ED3AD.6040403@freescale.com> (raw)
In-Reply-To: <20130523101921.GM18614@n2100.arm.linux.org.uk>
? 2013?05?23? 18:19, Russell King - ARM Linux ??:
> On Thu, May 23, 2013 at 04:16:13PM +0800, Huang Shijie wrote:
>> + /* get the clock */
>> + weim->clk = devm_clk_get(&pdev->dev, NULL);
>> + if (IS_ERR(weim->clk))
>> + goto weim_err;
>> +
>> + clk_prepare_enable(weim->clk);
> I notice people are getting lazy about this. clk_prepare_enable() can
> return an error...
>
i will add the error check in next version.
thanks
Huang Shijie
next prev parent reply other threads:[~2013-05-24 2:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 8:16 [PATCH V2 0/6] ARM: imx6q{dl}: add the WEIM driver Huang Shijie
2013-05-23 8:16 ` [PATCH V2 1/6] drivers: bus: add a new driver for WEIM Huang Shijie
2013-05-23 8:46 ` Alexander Shiyan
2013-05-23 9:02 ` Huang Shijie
2013-05-23 9:23 ` Sascha Hauer
2013-05-23 9:35 ` Huang Shijie
2013-05-23 9:53 ` Arnd Bergmann
2013-05-23 11:55 ` Sascha Hauer
2013-05-23 13:09 ` Arnd Bergmann
2013-05-24 7:16 ` Huang Shijie
2013-05-24 7:19 ` Sascha Hauer
2013-05-23 10:19 ` Russell King - ARM Linux
2013-05-24 2:42 ` Huang Shijie [this message]
2013-05-23 8:16 ` [PATCH V2 2/6] ARM: dts: imx6q{dl}: fix the pin conflict between SPI and WEIM Huang Shijie
2013-05-23 8:16 ` [PATCH V2 3/6] ARM: dts: imx6qdl: add more information for WEIM Huang Shijie
2013-05-23 8:16 ` [PATCH V2 4/6] ARM: dts: imx6q: add pinctrl for WEIM NOR Huang Shijie
2013-05-23 9:14 ` Alexander Shiyan
2013-05-23 9:27 ` Huang Shijie
2013-05-23 9:39 ` Re[2]: " Alexander Shiyan
2013-05-23 9:52 ` Huang Shijie
2013-05-23 9:55 ` Re[2]: " Alexander Shiyan
2013-05-24 2:41 ` Huang Shijie
2013-05-23 8:16 ` [PATCH V2 5/6] ARM: dts: imx6dl: add a " Huang Shijie
2013-05-23 8:16 ` [PATCH V2 6/6] ARM: dts: imx6qdl: enable the " Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519ED3AD.6040403@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).